1935377 - Stop canceling Ion compilations and discarding JIT code when sweeping

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

Canceling happens here and after that we also discard JIT code.

I think this was required for the read-barriered JitZone stubs, but that should no longer be an issue after bug 1934972. At the start of GC we also discard JIT code based on some heuristics and it would be nice to do this only once per GC.

Comment 1

[Jan de Mooij [:jandem]]

Matt, I'll NI you because you're doing other clean-up work in this area and I expect this will be good for performance.

I hope this will Just Work after bug 1934972, but if not it will at least tell us more about other dependencies.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Gonna convert this to a reminder for next year rather than keep getting emails.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1935377 - Stop canceling Ion compilations and discarding JIT code during GC sweeping. r?jonco!

Now with Warp and after bug 1934972 we no longer need to discard twice during an incremental GC.

This improves some of the TodoMVC-React-Complex-DOM Sp3 sub-tests by 1-2%.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f3de76afbbe
Stop canceling Ion compilations and discarding JIT code during GC sweeping. r=jonco

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4f3de76afbbe