Open Bug 1935387 Opened 3 months ago Updated 2 months ago

Remove usages of textAllCaps

Categories

(Fenix :: Design System and Theming, defect)

All
Android
defect

Tracking

(Not tracked)

People

(Reporter: henry-x, Unassigned)

References

Details

This was noticed in Tor Browser development.

A few components force all-caps using textAllCaps="true". Including reused widgets like snackbar and infobar.

Forcing all-caps can have bad effects in some locales, like gaelic and greek. See https://mozilla-l10n.github.io/documentation/localization/dev_best_practices.html#css-issues.

In these cases where all caps is desirable, the en-US string itself should be capitalised, but the localisers should determine the capitalisation of the translation.

I'm hoping this could be a meta-issue to remove the forced-capitalisation.

See Also: → 1935389

Related desktop issue: bug 1935389.

This seems like something Android engineers should be fixing (not the localization team), but not sure under which component it should live in, though.
need info Olivia to help triage.

Flags: needinfo?(ohall)

Thank you for reporting this bug!

I'm moving this to Design System and Theming for triage because the L10N component isn't a well established engineering component yet. (I'll try and get the L10N component reviewed by an engineering triage group as well.)

I noticed these are XML and not in compose - there is an effort to generally move towards to compose. Updating this might need to be a part of one of those initiitives.

Component: L10N → Design System and Theming
Flags: needinfo?(ohall)

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jboek)

Taking a note to do two things here

  1. Create a task to remove all instances of textAllCaps="true" and update the impacted strings
  2. Figure out how we want to prevent new occurrences from being introduced.

Noah, what are your thoughts with #2? We could possibly just add a lint rule?

Severity: -- → S3
Flags: needinfo?(jboek) → needinfo?(nbond)
Summary: Forced all caps with textAllCaps → Remove usages of textAllCaps

(In reply to Jeff Boek [:boek] from comment #5)

Taking a note to do two things here

  1. Create a task to remove all instances of textAllCaps="true" and update the impacted strings
  2. Figure out how we want to prevent new occurrences from being introduced.

Noah, what are your thoughts with #2? We could possibly just add a lint rule?

#2 should certainly be possible with a Lint rule

Flags: needinfo?(nbond)
You need to log in before you can comment on or make changes to this bug.