1935391 - Crash in [@ java.lang.RuntimeException: at android.app.ActivityThread.callActivityOnStop(ActivityThread.java)]

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[twhite]

Crash report: https://crash-stats.mozilla.org/report/index/1baa857e-7a70-42a6-b5e7-99c230241205

Java stack trace:

java.lang.RuntimeException
    at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:5722)
    at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:5694)
    at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5758)
    at android.app.servertransaction.StopActivityItem.execute(StopActivityItem.java:40)
    at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:60)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:225)
    at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:107)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:81)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2636)
    at android.os.Handler.dispatchMessage(Handler.java:107)
    at android.os.Looper.loopOnce(Looper.java:232)
    at android.os.Looper.loop(Looper.java:317)
    at android.app.ActivityThread.main(ActivityThread.java:8705)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

In my crash reports this listed:

java.lang.RuntimeException: Unable to stop activity {org.mozilla.firefox_beta/ org.mozilla.firefox_beta.AlternativeApp}: java.lang. IllegalArgumentException: Manifest shortcut ID=open_new_private_tab may not be manipulated via APls

The top bit from crash-stats is:

0 	android.os.Parcel 	createExceptionOrNull 	Parcel.java:3246 	True
1 	android.os.Parcel 	createException 	Parcel.java:3226 	True
2 	android.os.Parcel 	readException 	Parcel.java:3209 	True
3 	android.os.Parcel 	readException 	Parcel.java:3151 	True
4 	android.content.pm.IShortcutService$Stub$Proxy 	updateShortcuts 	IShortcutService.java:668 	True
5 	android.content.pm.ShortcutManager 	updateShortcuts 	ShortcutManager.java:325 	True
6 	androidx.core.content.pm.ShortcutManagerCompat$$ExternalSyntheticApiModelOutline4 	m 	R8$$SyntheticClass:1 	True
7 	org.mozilla.fenix.utils.ChangeAppLauncherIconKt 	updateShortcutsComponentName 	ChangeAppLauncherIcon.kt:52 	True
8 	org.mozilla.fenix.HomeActivity 	onStop 	HomeActivity.kt:188 	True
9 	android.app.Instrumentation 	callActivityOnStop 	Instrumentation.java:1742 	True
10 	android.app.Activity 	performStop 	Activity.java:9255 	True
11 	android.app.ActivityThread 	callActivityOnStop 	ActivityThread.java:5714 	True

so this looked related to this experiment tripping the code in https://searchfox.org/mozilla-central/rev/8c9c85c74e366c11ffacbb5a2e457b33b0acc9cd/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/ChangeAppLauncherIcon.kt that interacts with the Android shortcutmanager. This code was last touched in bug 1928949.

Comment 3

[:Gijs (he/him)]

When this hit me the app crashed whenever it was backgrounded. It also crashed when opening the list of crashes from the settings page. It looks like the stack I posted shows how the action of backgrounding the app trips the code in question. (Via HomeActivity onStop)
It's possible further exploration of crash-stats could reveal why trying to look at the crashes trips the same code.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Browser Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.

Comment 8

[Jeff Boek [:boek]]

Hey Tom, is this still an issue? I still see crashes trickling in.

Comment 9

[twhite]

Thanks for the ping Jeff. So far it looks like these crashes are related to users who have not yet got the 'fix' patch landed in 134.0b8, until these users recieve the update or do a fresh install/remove all saved shortcuts they will unfortunately still get this crash

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mavduevskiy, could you have a look please?

For more information, please visit BugBot documentation.