1935430 - The profile name should be removed from the FxA account submenu located in the hamburger menu.

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Attachment: Screen Recording 2024-12-04 at 15.57.23.mov

Found in:
Nightly 135.0a1

Affected versions:
Nightly 135.0a1

Tested platforms:
Affected platforms: macOS 13.2.1, Windows 10

Preconditions:
Ensure that the pref "browser.profiles.enabled" is set to true in about:config and the user is signed into Sync with FxA account1.

Steps to reproduce:

1. Click to open the hamburger menu
2. Click on the FxA account1 name submenu
3. Observe the submenu.

Expected result:
Based on the Figma specs, the profile name should not be displayed on the FxA account submenu from the hamburger menu.

Actual result:
The profile name is displayed in the FxA account submenu from the hamburger menu. Please review the attached video for reference.

Regression range:
This is not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm no longer able to reproduce this bug - I think it may have been fixed by the patch for bug 1935600.

Could you take a look to confirm?

Comment 3

[Raluca Popovici, Desktop QA]

Verified as fixed by the patch for bug 1935600 using the latest Nightly 137.0a1 (2025-02-21) on macOS 13.2.1 and Windows 10.
This issue can be closed.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Great, thank you!

Comment 5

[Raluca Popovici, Desktop QA]

After taking a closer look, reviewing the Figma specs again, and confirming with Jared, I will go ahead and reopen this issue. The profile name should be removed from the FxA account submenu located in the Hamburger menu.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1935430 - Hide the profiles menuitem in the FxA panel when it is opened as an app menu subpanel. r?#profiles-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18aa100cff81
Hide the profiles menuitem in the FxA panel when it is opened as an app menu subpanel. r=profiles-reviewers,desktop-theme-reviewers,mossop,cmkm

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/18aa100cff81

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhirsch, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

No, this feature is behind a pref in 137 beta/release, so there's no need to bother with an uplift.

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I'm not sure if 'wontfix' is a better choice than 'disabled', but going with BugBot's advice here

Comment 13

[Donal Meehan [:dmeehan]]

'disabled' is better; you're correct that the bot is misleading in this scenario. I will add it to a to-do list to improve the bot wording.

Comment 14

[Daniel Bodea [:danibodea]]

I can reproduce this issue in Release v137.0.2 and I can confirm the fix in Beta v138.0 (RC). The name of the profile is no longer displayed in the Sync Account submenu when at least 1 other profile was created.

If the user only enables this feature (browser.profiles.enabled=true) and DOES NOT create an account, then the "Profiles" submenu will be displayed in the Hamburger menu AND the inside the Fx Sync submenu. I assume this should also apply in this case.

Jared, what are your thoughts? Should I log another bug for that case?

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Looking at the Figma, it seems like the intent is for the profiles menuitem to be shown in the sync menu whether or not they are signed in to sync. I think it is currently working as designed.