1935511 - Allow incrementing Translation model versions while maintaining compatiblility with previous versions

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Erik Nordin [:nordzilla]]

Description

The fix from Bug 1926100 introduces a cutoff point at which our larger "base" models are only compatible with versions of Firefox that contain that patch.

Likewise, the switch to the Bergamot WASM binary version 2.0 from Bug 1917851 introduces a similar cutoff point at which CJK models will only be compatible in versions of Firefox that contain that patch stack.

However, all of our current 1.x version models are compatible with both of the above source code changes. As such, we need to introduce a way to increment our model versions while still utilizing previous models that are backward compatible with the new changes.

We should adjust the hard-coded model versioning constraints for the models to be a range of major versions, rather than a single major version. This will allow us to increment the maximum supported version while maintaining the minimum supported version.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1935511 - Rename getMaxVersionRecords r=#translations-reviewers!

Renames the getMaxVersionRecords() function to
getMaxSupportedVersionRecords() because I think
it improves overall clarity and readability.

The record that is retrieved may not be the absolute
maximum record, but only the maximum that is supported
in this version of the source code.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1935511 - Rename LANGUAGE_MODEL_MAJOR_VERSION r=#translations-reviewers!

Renames LANGUAGE_MODEL_MAJOR_VERSION to
LANGUAGE_MODEL_MAJOR_VERSION_MAX in preparation
for the changes following patch. This will reduce
noise and make the overall review of the logical
code changes easier to digest.

Depends on D231316

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1935511 - Improve Translations Model Version Strategy r=#translations-reviewers!

This patch improves the strategy around how we tie supported
Translations model versions to the source code by allowing us to
introduce new model versions while also allowing forward-compatible
models with older versions to still be used.

Depends on D231317

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2b3c81ed886
Rename getMaxVersionRecords r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/cf8349221ae2
Rename LANGUAGE_MODEL_MAJOR_VERSION r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/2758b817c3b8
Improve Translations Model Version Strategy r=translations-reviewers,gregtatum

Comment 5

[agoloman]

Backed out for causing junit failures.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Erik Nordin [:nordzilla]]

I believe that I have fixed the issue on Android.

The junit tests are looking clean on the latest try run:
https://treeherder.mozilla.org/jobs?repo=try&revision=7c264c26e8f32892043d8cf66def5662c8fd3b97

---

Going to try re-landing.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d7743d3408a
Rename getMaxVersionRecords r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/6db34740bb10
Rename LANGUAGE_MODEL_MAJOR_VERSION r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/03677f24ea9a
Improve Translations Model Version Strategy r=translations-reviewers,gregtatum

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8d7743d3408a
https://hg.mozilla.org/mozilla-central/rev/6db34740bb10
https://hg.mozilla.org/mozilla-central/rev/03677f24ea9a