1935513 - Add a heading to moz-page-nav in about:policies

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, task)

Description

[Hanna Jones [:hjones]]

Bug 1927215 added a heading to moz-page-nav. When reviewing that work I missed that we are already using moz-page-nav in about:policies here. That page also needs a heading now, probably just "About Policies" or "Policies" would work. You can find an example of how the Fluent needs to be formatted for this here and of usage here.

Comment 1

[Mark Striemer [:mstriemer]]

I think this is technically related to the policies component, but adding some recomp mentors since we're happy to help out

Comment 2

[Harold Camacho]

Attachment: WIP: Bug 1935513 - Add a heading to moz-page-nav in about:policies

Comment 3

[Harold Camacho]

Hi Hannah, nice to meet you! I added a heading to the moz-page-nav. Please let me know if these changes are okay.

Thank you!

Comment 4

[Hanna Jones [:hjones]]

Hey Harold, thanks for the patch! I left a small comment, but otherwise the changes look good to me. Mind taking it out of wip that was I can approve it. You should be able to either remove "WIP" from the commit message or do moz-phab submit without the --wip flag

Comment 5

[Harold Camacho]

Attachment: Bug 1935513 - Add a heading to moz-page-nav in about:policies. r?hjones

Comment 6

[Harold Camacho]

Done! I’ve taken the patch out of wip and removed the small redundancy as you suggested.

Thanks! If there are any other bugs I can help with, I’d love to keep contributing. Let me know! Appreciate it!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/055bce10ae62
Add a heading to moz-page-nav in about:policies. r=hjones,fluent-reviewers,bolsson

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/055bce10ae62

Comment 9

[Mike Kaply [:mkaply]]

Don't forget to abandon the revision you didn't use.