1935517 - Deprecate --in-content-focus-* variables in favour of --focus-outline-* design tokens

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Hanna Jones [:hjones]]

We have a series of --in-content-focus-* variables in common-shared.css that are already using our --focus-outline-* design tokens under the hood. It would be a nice bit of cleanup to remove the --in-content-* versions of these variables so that it's clearer to developers which variables they should use in their patches. This should be straightforward with the exception of cases like this one:

outline: 2px solid var(--in-content-focus-outline-color);

which should be changed to:

outline: var(--focus-outline);

That's just to say the replacements should be evaluated on a case by case basis, rather than just doing a find and replace.

Comment 1

[Catherine Meade]

Attachment: Bug 1935517 - Deprecate references to in-content-focus. r=#reusable-components-reviewers,hjones

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/430ef42997c5
https://hg.mozilla.org/integration/autoland/rev/2b2a114e8fe2
Deprecate references to in-content-focus. r=hjones,reusable-components-reviewers,mtigley,desktop-theme-reviewers,credential-management-reviewers,fxview-reviewers,home-newtab-reviewers,nsharpley,nbarrett

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2b2a114e8fe2