1935528 - Remove sticky header functionality from wordmark on homepage

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, task, P3)

Description

[Devota Aabel [:devota]]

Current Behavior:

Tapping near the logo and then scroll gives you a sticky firefox logo. 

Desired Behavior:

This should be removed and everywhere you tap a scroll should function with the same scroll never pinning the logo to the top

Comment 1

[Devota Aabel [:devota]]

Attachment: Bug 1935528: Removed Collapsing Toolbar Layout so that firefox wordmark always scrolls and is never a sticky header

Comment 2

[Devota Aabel [:devota]]

Attachment: Bug 1935528: Created new homepage header for compose. Moved setting of browsing mode into PrivateBrowsingController. r=gl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35bc57c5e840
Created new homepage header for compose. Moved setting of browsing mode into PrivateBrowsingController. r=gl,android-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing fenix opt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.fenix.home.PrivateBrowsingButtonViewTest.click listener calls onClick with inverted mode from private mode | java.lang.AssertionError: Verification failed: call 1 of 1: BrowsingModeManager(#248).setMode(eq(Normal))) was not called.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3adbe4decb2
Created new homepage header for compose. Moved setting of browsing mode into PrivateBrowsingController. r=gl,android-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e3adbe4decb2