Closed Bug 1935692 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 49570 - [css-nesting] Don't re-nest CSSNestedDeclarations in @scope

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49570 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49570
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[css-nesting] Don't re-nest CSSNestedDeclarations in @scope

These rules are currently always re-nested by having their selector
list re-copied. This is the correct behavior when nested inside
style rules (CSSNestingType::kNesting), but not when nested inside
@scope (CSSNestingType::kScope).

Fixed: 363019839
Change-Id: I45cef3d8226ed496f0441b26c18120f6a43d74e9
Reviewed-on: https://chromium-review.googlesource.com/6070291
WPT-Export-Revision: 7804eeda5a83e953f7d441db94733966787fb24b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 23 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 22

Chrome

OK : 1
PASS: 23

Safari

OK : 1
PASS: 21
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-cascade/scope-nesting.html [wpt.fyi]
    • Implicit :scope in <scope-end>: FAIL linked bug:Bug 1873611
    • Relative selectors in <scope-end>: FAIL linked bug:Bug 1873611
    • Nesting-selector in the scope's <stylesheet>: FAIL linked bug:Bug 1873611
    • Nesting-selector within :scope rule: FAIL linked bug:Bug 1873611
    • Nesting-selector within :scope rule (double nested): FAIL linked bug:Bug 1873611
    • @scope nested within style rule: FAIL linked bug:Bug 1873611
    • Parent pseudo class within scope-start: FAIL linked bug:Bug 1873611
    • Parent pseudo class within scope-end: FAIL linked bug:Bug 1873611
    • Parent pseudo class within body of nested @scope: FAIL linked bug:Bug 1873611
    • Implicit rule within nested @scope : FAIL linked bug:Bug 1873611
    • Implicit rule within nested @scope (proximity): FAIL linked bug:Bug 1873611
    • Nested :scope inside an :is: FAIL linked bug:Bug 1873614
    • :scope within nested and scoped rule: FAIL linked bug:Bug 1873614
    • :scope within nested and scoped rule (implied &): FAIL linked bug:Bug 1873614
    • :scope within nested and scoped rule (relative): FAIL linked bug:Bug 1873614
    • Scoped nested group rule: FAIL linked bug:Bug 1873614
    • Scoped nested within another scope: FAIL
    • Implicit (prelude-less) @scope as a nested group rule: FAIL
    • Insert a nested style rule within @scope, &: FAIL
    • Mutating selectorText on outer style rule causes correct inner specificity: FAIL

New Tests That Don't Pass

  • /css/css-cascade/scope-nesting.html [wpt.fyi]
    • Implicit :scope in <scope-end>: FAIL (Chrome: PASS, Safari: PASS)
    • Relative selectors in <scope-end>: FAIL (Chrome: PASS, Safari: PASS)
    • Nesting-selector in the scope's <stylesheet>: FAIL (Chrome: PASS, Safari: PASS)
    • Nesting-selector within :scope rule: FAIL (Chrome: PASS, Safari: PASS)
    • Nesting-selector within :scope rule (double nested): FAIL (Chrome: PASS, Safari: PASS)
    • @scope nested within style rule: FAIL (Chrome: PASS, Safari: PASS)
    • Parent pseudo class within scope-start: FAIL (Chrome: PASS, Safari: PASS)
    • Parent pseudo class within scope-end: FAIL (Chrome: PASS, Safari: PASS)
    • Parent pseudo class within body of nested @scope: FAIL (Chrome: PASS, Safari: PASS)
    • Implicit rule within nested @scope : FAIL (Chrome: PASS, Safari: PASS)
    • Implicit rule within nested @scope (proximity): FAIL (Chrome: PASS, Safari: PASS)
    • Nested :scope inside an :is: FAIL (Chrome: PASS, Safari: PASS)
    • :scope within nested and scoped rule: FAIL (Chrome: PASS, Safari: PASS)
    • :scope within nested and scoped rule (implied &): FAIL (Chrome: PASS, Safari: PASS)
    • :scope within nested and scoped rule (relative): FAIL (Chrome: PASS, Safari: PASS)
    • Scoped nested group rule: FAIL (Chrome: PASS, Safari: PASS)
    • Scoped nested within another scope: FAIL (Chrome: PASS, Safari: PASS)
    • Implicit (prelude-less) @scope as a nested group rule: FAIL (Chrome: PASS, Safari: PASS)
    • Insert a nested style rule within @scope, &: FAIL (Chrome: PASS, Safari: PASS)
    • Insert a nested style rule within @scope, :scope: FAIL (Chrome: PASS, Safari: FAIL)
    • Insert a CSSNestedDeclarations rule directly in top-level @scope: FAIL (Chrome: PASS, Safari: FAIL)
    • Mutating selectorText on outer style rule causes correct inner specificity: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9855fce70a58 [wpt PR 49570] - [css-nesting] Don't re-nest CSSNestedDeclarations in @scope, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9855fce70a58

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.