1935753 - 3.58 - 3.47% pdfpaint issue8078.pdf / pdfpaint issue8078.pdf (Windows) regression on Tue December 3 2024

Status: RESOLVED WONTFIX

(Core :: JavaScript: GC, defect, P4)

Description

[Treeherder Bug Filer]

Perfherder has detected a talos performance regression from push 1a8b6c677e25084ce731e47a40b775f39ab75275. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	pdfpaint issue8078.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	2,090.22 -> 2,165.02
3%	pdfpaint issue8078.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	2,098.32 -> 2,171.18

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43002

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1932751

Comment 2

[Mayank Bansal]

Here are the corresponding graphs for Linux and Mac (1015 and 1470) : https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&replicates=0&series=autoland,5094157,1,1&series=autoland,5094655,1,1&series=autoland,5098036,1,1&series=autoland,5098335,1,1&series=autoland,299655,1,1&series=autoland,301200,1,1&timerange=2592000&zoom=1730943090938,1733550291472,2823.1755555555565,8123.584444444444

Out of these 6, only the Mac1015 shows some regression around the time the regressor landed. But the graph then starts improving.

Comment 3

[Jon Coppeard (:jonco)]

I think we should take this regression.

It might be worth checking whether there is extra time spent tracing store buffers in nursery collection for this benchmark, to see if the change is actually related to this push. If so it might be worth making us coalescing entries in the slots edge store buffer more eagerly but I think it's unlikely to be much of a win.

Comment 4

[Greg Mierzwinski [:sparky]]

Resolving as WONTFIX due to comment 3, and that we've increased the alerting threshold to 6%.