1935782 - Tests only have an empty array for the field result.moz_validation for the actor ManifestMessages, message DOM:ManifestObtainer:Obtain

Status: NEW

(Core :: DOM: Core & HTML, task)

Description

[Andrew McCreight [:mccr8]]

For bug 1885221, I have added logging for all JS actor messages that we generate during testing.

For the "DOM:ManifestObtainer:Obtain" message of the ManifestMessages actor, here's an excerpt of the type we infer for the query reply from the child to the parent:

{
  result:
    | null
    | {
        ...
        moz_validation?: Array<never>;
        ...
          }
    | {
       ...
       };
  success: boolean;
}

This means that the result field can be an object which optionally has a property moz_validation. If present, the property is only ever an empty array, which means we're not really testing this thoroughly. I should add that my testing so far has only been on desktop, and it looks like this is related to PWA manifest stuff which is better supported for Fenix, so maybe there is testing there.

It looks like this field is used to pass back errors. I do see some instances of moz_validation in tests, so maybe this feature is tested without going over IPC.