1935812 - Compile libjxl as C++17

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, task, P3)

Description

[Chris Peterson [:cpeterson]]

We've been compiling libjxl as C++11 to work around a C++17 bug in clang 5: https://gitlab.com/wg1/jpeg-xl/-/issues/227

Now that our base toolchain's minimum clang version is 8, there is no need to force C++11. Here is a green try build compiling libjxl as C++17 with the base clang and gcc toolchains:

https://treeherder.mozilla.org/jobs?repo=try&revision=5b118c687ca4371675c973afddf1b2cae94b4645&searchStr=Bb

(The Bp-clang-truck error in that try push is unrelated clang bug 1935311.)

Comment 1

[Chris Peterson [:cpeterson]]

Compiling libjxl as C++17 will also silence these warnings about using C++17's static_assert with no message in C++11 code:

third_party/jpeg-xl/lib/jxl/dec_modular.cc:109:52 [-Wc++17-extensions] 'static_assert' with no message is a C++17 extension
third_party/jpeg-xl/lib/jxl/icc_codec_common.cc:73:44 [-Wc++17-extensions] 'static_assert' with no message is a C++17 extension
third_party/jpeg-xl/lib/jxl/image.h:151:33 [-Wc++17-extensions] 'static_assert' with no message is a C++17 extension
third_party/jpeg-xl/lib/jxl/modular/transform/palette.h:45:27 [-Wc++17-extensions] 'static_assert' with no message is a C++17 extension
third_party/jpeg-xl/lib/jxl/quant_weights.h:80:43 [-Wc++17-extensions] 'static_assert' with no message is a C++17 extension

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1935812 - Compile libjxl as C++17. r?#media-playback-reviewers,saschanaz?

We've been compiling libjxl as C++11 to work around a C++17 bug in clang 5: https://gitlab.com/wg1/jpeg-xl/-/issues/227

Now that our base toolchain's minimum clang version is 8, there is no need to force C++11.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01166de9b45b
Compile libjxl as C++17. r=tnikkel,saschanaz?

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01166de9b45b