Closed Bug 1935918 Opened 3 months ago Closed 3 months ago

Perma [tier 2] Snap nightly 2 out of 3 hunks FAILED -- rejects in file toolkit/components/extensions/NativeManifests.sys.mjs

Categories

(Firefox Build System :: Third Party Packaging, defect, P1)

Product:
Firefox Build System
Component:
Third Party Packaging
Type:
defect

Tracking

(firefox-esr128 unaffected, firefox133 unaffected, firefox134 unaffected, firefox135 fixed)

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox-esr128 --- unaffected
firefox133 --- unaffected
firefox134 --- unaffected
firefox135 --- fixed

People

(Reporter: abutkovits, Assigned: gerard-majax)

References

Details

(Keywords: regression)

Attachments

(1 file)

GitHub Pull Request
49 bytes, text/x-github-pull-request
Details | Review

Full log: https://firefoxci.taskcluster-artifacts.net/M4IaFbKWQnqvQBcGVWRf0Q/0/public/logs/live_backing.log

[task 2024-12-09T00:19:18.197Z] :: patching file modules/libpref/init/StaticPrefList.yaml
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 succeeded at 17719 with fuzz 1 (offset 333 lines).
[task 2024-12-09T00:19:18.198Z] :: patching file python/mozbuild/mozbuild/mozinfo.py
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 succeeded at 156 (offset 2 lines).
[task 2024-12-09T00:19:18.198Z] :: patching file python/sites/xpcshell-test.txt
[task 2024-12-09T00:19:18.198Z] :: patching file testing/mozharness/configs/unittests/linux_unittest.py
[task 2024-12-09T00:19:18.198Z] :: patching file testing/xpcshell/mach_commands.py
[task 2024-12-09T00:19:18.198Z] :: patching file toolkit/components/extensions/NativeManifests.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.198Z] :: Hunk #2 FAILED at 89.
[task 2024-12-09T00:19:18.198Z] :: Hunk #3 succeeded at 176 (offset 18 lines).
[task 2024-12-09T00:19:18.198Z] :: 2 out of 3 hunks FAILED -- rejects in file toolkit/components/extensions/NativeManifests.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: patching file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.198Z] :: Hunk #2 succeeded at 26 with fuzz 2 (offset 7 lines).
[task 2024-12-09T00:19:18.198Z] :: Hunk #3 FAILED at 56.
[task 2024-12-09T00:19:18.198Z] :: Hunk #4 FAILED at 74.
[task 2024-12-09T00:19:18.198Z] :: Hunk #5 FAILED at 81.
[task 2024-12-09T00:19:18.198Z] :: Hunk #6 succeeded at 214 with fuzz 1 (offset 84 lines).
[task 2024-12-09T00:19:18.198Z] :: Hunk #7 succeeded at 467 with fuzz 2 (offset 100 lines).
[task 2024-12-09T00:19:18.198Z] :: 4 out of 7 hunks FAILED -- rejects in file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: The next patch would create the file toolkit/components/extensions/NativeMessagingPortal.cpp,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/NativeMessagingPortal.h,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.h
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/NativeMessagingPortal.h
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/components.conf
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 14.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/components.conf
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/docs/native-messaging-portal-design.rst,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/docs/native-messaging-portal-design.rst
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/docs/native-messaging-portal-design.rst
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/moz.build
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 77.
[task 2024-12-09T00:19:18.199Z] :: Hunk #2 succeeded at 114 with fuzz 2 (offset 11 lines).
[task 2024-12-09T00:19:18.199Z] :: 1 out of 2 hunks FAILED -- rejects in file toolkit/components/extensions/moz.build
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/nsINativeMessagingPortal.idl,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.200Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/native_messaging.toml
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 20 with fuzz 2 (offset 4 lines).
[task 2024-12-09T00:19:18.200Z] :: The next patch would create the file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js,
[task 2024-12-09T00:19:18.200Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.200Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/test_native_manifests.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 244 with fuzz 2 (offset 94 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/Subprocess.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 201 with fuzz 2 (offset 13 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_common.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #2 succeeded at 654 with fuzz 1 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: Hunk #3 succeeded at 699 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: Hunk #4 succeeded at 737 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_unix.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 202 with fuzz 2 (offset 4 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_unix.worker.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #3 succeeded at 629 (offset 90 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_win.sys.mjs
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 succeeded at 174 with fuzz 2 (offset 6 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_win.worker.js
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 succeeded at 607 with fuzz 1 (offset 6 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_worker_common.js
[task 2024-12-09T00:19:18.201Z] :: Hunk #3 succeeded at 120 with fuzz 1 (offset 9 lines).
[task 2024-12-09T00:19:18.201Z] :: Hunk #4 succeeded at 200 with fuzz 2 (offset 21 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/test/xpcshell/test_subprocess.js
[task 2024-12-09T00:19:18.201Z] :: patching file widget/gtk/WidgetUtilsGtk.cpp
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 FAILED at 214.
[task 2024-12-09T00:19:18.201Z] :: 1 out of 1 hunk FAILED -- rejects in file widget/gtk/WidgetUtilsGtk.cpp
[task 2024-12-09T00:19:18.201Z] :: patching file widget/gtk/WidgetUtilsGtk.h
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 FAILED at 53.
[task 2024-12-09T00:19:18.201Z] :: 1 out of 1 hunk FAILED -- rejects in file widget/gtk/WidgetUtilsGtk.h
[task 2024-12-09T00:19:18.201Z] :: Patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch does not apply (enforce with -f)
[task 2024-12-09T00:19:18.333Z] 'override-pull' in part 'firefox' failed with code 1.
[task 2024-12-09T00:19:18.335Z] Recommended resolution: Review the scriptlet and make sure it's correct.
[task 2024-12-09T00:19:18.335Z] Full execution log: '/builds/worker/.local/state/snapcraft/log/snapcraft-20241209-001320.566329.log'
[taskcluster 2024-12-09 00:19:22.305Z] === Task Finished ===
[taskcluster 2024-12-09 00:19:22.601Z] Unsuccessful task run with exit code: 1 completed in 538.588 seconds[task 2024-12-09T00:19:18.197Z] :: Applying patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch
[task 2024-12-09T00:19:18.197Z] :: patching file modules/libpref/init/StaticPrefList.yaml
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 succeeded at 17719 with fuzz 1 (offset 333 lines).
[task 2024-12-09T00:19:18.198Z] :: patching file python/mozbuild/mozbuild/mozinfo.py
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 succeeded at 156 (offset 2 lines).
[task 2024-12-09T00:19:18.198Z] :: patching file python/sites/xpcshell-test.txt
[task 2024-12-09T00:19:18.198Z] :: patching file testing/mozharness/configs/unittests/linux_unittest.py
[task 2024-12-09T00:19:18.198Z] :: patching file testing/xpcshell/mach_commands.py
[task 2024-12-09T00:19:18.198Z] :: patching file toolkit/components/extensions/NativeManifests.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.198Z] :: Hunk #2 FAILED at 89.
[task 2024-12-09T00:19:18.198Z] :: Hunk #3 succeeded at 176 (offset 18 lines).
[task 2024-12-09T00:19:18.198Z] :: 2 out of 3 hunks FAILED -- rejects in file toolkit/components/extensions/NativeManifests.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: patching file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.198Z] :: Hunk #2 succeeded at 26 with fuzz 2 (offset 7 lines).
[task 2024-12-09T00:19:18.198Z] :: Hunk #3 FAILED at 56.
[task 2024-12-09T00:19:18.198Z] :: Hunk #4 FAILED at 74.
[task 2024-12-09T00:19:18.198Z] :: Hunk #5 FAILED at 81.
[task 2024-12-09T00:19:18.198Z] :: Hunk #6 succeeded at 214 with fuzz 1 (offset 84 lines).
[task 2024-12-09T00:19:18.198Z] :: Hunk #7 succeeded at 467 with fuzz 2 (offset 100 lines).
[task 2024-12-09T00:19:18.198Z] :: 4 out of 7 hunks FAILED -- rejects in file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2024-12-09T00:19:18.198Z] :: The next patch would create the file toolkit/components/extensions/NativeMessagingPortal.cpp,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/NativeMessagingPortal.h,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.h
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/NativeMessagingPortal.h
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/components.conf
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 14.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/components.conf
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/docs/native-messaging-portal-design.rst,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/docs/native-messaging-portal-design.rst
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.199Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/docs/native-messaging-portal-design.rst
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/moz.build
[task 2024-12-09T00:19:18.199Z] :: Hunk #1 FAILED at 77.
[task 2024-12-09T00:19:18.199Z] :: Hunk #2 succeeded at 114 with fuzz 2 (offset 11 lines).
[task 2024-12-09T00:19:18.199Z] :: 1 out of 2 hunks FAILED -- rejects in file toolkit/components/extensions/moz.build
[task 2024-12-09T00:19:18.199Z] :: The next patch would create the file toolkit/components/extensions/nsINativeMessagingPortal.idl,
[task 2024-12-09T00:19:18.199Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.199Z] :: patching file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.200Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/native_messaging.toml
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 20 with fuzz 2 (offset 4 lines).
[task 2024-12-09T00:19:18.200Z] :: The next patch would create the file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js,
[task 2024-12-09T00:19:18.200Z] :: which already exists!  Applying it anyway.
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 FAILED at 1.
[task 2024-12-09T00:19:18.200Z] :: 1 out of 1 hunk FAILED -- rejects in file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/components/extensions/test/xpcshell/test_native_manifests.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 244 with fuzz 2 (offset 94 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/Subprocess.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 201 with fuzz 2 (offset 13 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_common.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #2 succeeded at 654 with fuzz 1 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: Hunk #3 succeeded at 699 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: Hunk #4 succeeded at 737 (offset 10 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_unix.sys.mjs
[task 2024-12-09T00:19:18.200Z] :: Hunk #1 succeeded at 202 with fuzz 2 (offset 4 lines).
[task 2024-12-09T00:19:18.200Z] :: patching file toolkit/modules/subprocess/subprocess_unix.worker.js
[task 2024-12-09T00:19:18.200Z] :: Hunk #3 succeeded at 629 (offset 90 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_win.sys.mjs
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 succeeded at 174 with fuzz 2 (offset 6 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_win.worker.js
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 succeeded at 607 with fuzz 1 (offset 6 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/subprocess_worker_common.js
[task 2024-12-09T00:19:18.201Z] :: Hunk #3 succeeded at 120 with fuzz 1 (offset 9 lines).
[task 2024-12-09T00:19:18.201Z] :: Hunk #4 succeeded at 200 with fuzz 2 (offset 21 lines).
[task 2024-12-09T00:19:18.201Z] :: patching file toolkit/modules/subprocess/test/xpcshell/test_subprocess.js
[task 2024-12-09T00:19:18.201Z] :: patching file widget/gtk/WidgetUtilsGtk.cpp
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 FAILED at 214.
[task 2024-12-09T00:19:18.201Z] :: 1 out of 1 hunk FAILED -- rejects in file widget/gtk/WidgetUtilsGtk.cpp
[task 2024-12-09T00:19:18.201Z] :: patching file widget/gtk/WidgetUtilsGtk.h
[task 2024-12-09T00:19:18.201Z] :: Hunk #1 FAILED at 53.
[task 2024-12-09T00:19:18.201Z] :: 1 out of 1 hunk FAILED -- rejects in file widget/gtk/WidgetUtilsGtk.h
[task 2024-12-09T00:19:18.201Z] :: Patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch does not apply (enforce with -f)
[task 2024-12-09T00:19:18.333Z] 'override-pull' in part 'firefox' failed with code 1.
[task 2024-12-09T00:19:18.335Z] Recommended resolution: Review the scriptlet and make sure it's correct.
[task 2024-12-09T00:19:18.335Z] Full execution log: '/builds/worker/.local/state/snapcraft/log/snapcraft-20241209-001320.566329.log'
[taskcluster 2024-12-09 00:19:22.305Z] === Task Finished ===
[taskcluster 2024-12-09 00:19:22.601Z] Unsuccessful task run with exit code: 1 completed in 538.588 seconds ```

Set release status flags based on info from the regressing bug 1661935

:gerard-majax, since you are the author of the regressor, bug 1661935, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox133: --- → unaffected
status-firefox134: --- → unaffected
status-firefox135: --- → affected
status-firefox-esr128: --- → unaffected
Flags: needinfo?(lissyx+mozillians)
Depends on: 1661935
Flags: needinfo?(lissyx+mozillians)
No longer regressed by: 1661935
Attached file GitHub Pull Request —
Assignee: nobody → lissyx+mozillians

That's not a regression, bug 1661935 holds the patch that used to be required on snap side. Now we have it on central and the PR to stop using it just needs to be merged

Severity: -- → S4
Priority: -- → P1
Component: General → Third Party Packaging
Product: WebExtensions → Firefox Build System

Upstream PR was merged and Snap builds are green on central.

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox135: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: