Closed Bug 1935937 Opened 2 months ago Closed 2 months ago

23.54 - 2.87% damp custom.netmonitor.close.DAMP / damp custom.jsdebugger.project-search.first-search-result.DAMP + 9 more (Linux, OSX, Windows) regression on Fri November 29 2024

Categories

(DevTools :: Shared Components, defect)

defect

Tracking

(firefox-esr128 unaffected, firefox133 unaffected, firefox134 unaffected, firefox135 affected)

RESOLVED INVALID
Tracking Status
firefox-esr128 --- unaffected
firefox133 --- unaffected
firefox134 --- unaffected
firefox135 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a devtools performance regression from push f54c2498a7af33c890d28814f0de63575c37a31f. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
24% damp custom.netmonitor.close.DAMP macosx1470-64-shippable e10s fission stylo webrender 16.56 -> 20.46
11% damp custom.jsdebugger.project-search.DAMP macosx1470-64-shippable e10s fission stylo webrender 2,128.26 -> 2,365.69
10% damp custom.jsdebugger.project-search.DAMP windows11-64-shippable-qr e10s fission stylo webrender 1,472.39 -> 1,625.56
10% damp custom.jsdebugger.project-search.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender 2,012.57 -> 2,221.29
8% damp custom.jsdebugger.project-search.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 2,449.50 -> 2,640.04
5% damp custom.jsdebugger.open-large-minified-file.DAMP windows11-64-shippable-qr e10s fission stylo webrender 45.96 -> 48.21
5% damp custom.jsdebugger.open-large-minified-file.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 56.91 -> 59.67
4% damp custom.jsdebugger.close.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 28.04 -> 29.22
3% damp custom.jsdebugger.open-large-minified-file.full-selection.DAMP macosx1470-64-shippable e10s fission stylo webrender 353.40 -> 365.06
3% damp custom.jsdebugger.preview.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 339.19 -> 349.21
3% damp custom.jsdebugger.project-search.first-search-result.DAMP windows11-64-shippable-qr e10s fission stylo webrender 248.72 -> 255.86

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
3% damp browser-toolbox.debugger-ready.DAMP macosx1470-64-shippable e10s fission stylo webrender 813.99 -> 786.08

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 42935

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to nchevobbe@mozilla.com.

Flags: needinfo?(ff2400t)

The Bugbug bot thinks this bug should belong to the 'DevTools::Netmonitor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Netmonitor

Set release status flags based on info from the regressing bug 1810427

Component: Netmonitor → Shared Components
Flags: needinfo?(ff2400t)

:ff2400t, since you are the author of the regressor, bug 1810427, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(ff2400t)

the regressor was backed out, I'll close this (we should be careful when trying to re-land the patch to check if there are still performance issues)

Status: NEW → RESOLVED
Closed: 2 months ago
Flags: needinfo?(ff2400t)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.