1935948 - Consider using original response headers for cookie parsing

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

Using the original headers means we don't need to deal with merged headers. This is temping because it would be a great cleanup in CookieParser.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1935948 - Split the cookie header at the channel level, r?edgul,valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/453ab78eb1ee
Use original response headers for cookie handling, r=edgul,valentin,cookie-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_ext_dnr_modifyHeaders.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/3fcdb50769b3baefcefe80c8a0bb4b9859be45be

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_dnr_modifyHeaders.js

Comment 4

[Serban Stanca [:SerbanS]]

Please also check these wpt failures.

• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df9c44d9fd0e
Split the cookie header at the channel level, r=edgul,valentin,cookie-reviewers

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/df9c44d9fd0e

Comment 7

[amarc]

Backed out for causing conflicts with Bug 1915355 : https://hg.mozilla.org/integration/autoland/rev/d8c30938863f81b48c0c3967eed0a7058509f85a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/866fd95260f4
Split the cookie header at the channel level, r=edgul,valentin,cookie-reviewers

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ CookieService.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/0b668ce4937c30d2da6e44326537b603f2112b12

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/cookie/CookieService.cpp

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b72a6d05f53
Split the cookie header at the channel level, r=edgul,valentin,cookie-reviewers

Comment 11

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/3b72a6d05f53

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Andrea, coverity (CID 1636971) complains on this change
https://searchfox.org/mozilla-central/source/netwerk/cookie/CookieServiceChild.cpp#500

continue_in_do_while_false: A continue statement within a do ... while (...) loop only continues execution of the loop body if the loop continuation condition is still true. Since the condition will never be true in a do ... while (false) loop, the continue statement has the same effect as a break statement. Did you intend execution to continue at the top of the loop?

is it legit ? if so, happy to open a bug

Comment 13

[Andrea Marchesini [:baku]]

I'll take a look and file a bug if needed.