1936092 - Remove tests for JSM loader

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

Part of bug 1881888, but filing separately given there are many tests for JSM loader and related APIs.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 1: Remove tests for JSM=>ESM shim. r?Standard8!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 2: Rewrite test for the shared system global to use ESM. r?Standard8!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 3: Remove tests for Cu.import. r?Standard8!

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 4: Remove tests for Cu.unload. r?Standard8!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 5: Remove tests for the JSM environments. r?Standard8!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 6: Remove tests for Cu.import. r?Standard8!

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 7: Remove tests for ChromeUtils.import. r?Standard8!

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 8: Remove tests for ChromeUtils.defineModuleGetter. r?Standard8!

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 9: Remove tests for Cu.getModuleImportStack. r?Standard8!

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 10: Remove tests for Cu.isModuleLoaded. r?Standard8!

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 11: Remove tests for Cu.loadedJSModules. r?Standard8!

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 12: Remove unused test resources. r?Standard8!

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936092 - Part 13: Update obsolete comments and assertion messages. r?Standard8!

Comment 14

[Andrew McCreight [:mccr8]]

I think some of these changes are far enough away from being a pure test infrastructure change that they should get XPConnect peer review. For instance, I think Peter should look at the changes that are tweaking how some of the expando and xray tests work. I can go through and an extra review on ones where I think it is relevant, once Phabricator starts working again.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc00c2522dbf
Part 1: Remove tests for JSM=>ESM shim. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/682e4e9d330b
Part 2: Rewrite test for the shared system global to use ESM. r=Standard8,peterv
https://hg.mozilla.org/integration/autoland/rev/f58508d78613
Part 3: Remove tests for Cu.import. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/61dea27fcb76
Part 4: Remove tests for Cu.unload. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/fba91011887a
Part 5: Remove tests for the JSM environments. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/203f8c5d9f76
Part 6: Remove tests for Cu.import. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/0169ea0af1a5
Part 7: Remove tests for ChromeUtils.import. r=Standard8,dom-storage-reviewers,mccr8,asuth
https://hg.mozilla.org/integration/autoland/rev/da29f4ffde2e
Part 8: Remove tests for ChromeUtils.defineModuleGetter. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/eb2316c9dab1
Part 9: Remove tests for Cu.getModuleImportStack. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/e7af9adfb3d1
Part 10: Remove tests for Cu.isModuleLoaded. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/01cf5d247a96
Part 11: Remove tests for Cu.loadedJSModules. r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/a526034b8066
Part 12: Remove unused test resources. r=Standard8,mccr8,asuth
https://hg.mozilla.org/integration/autoland/rev/3fbe0dc36d32
Part 13: Update obsolete comments and assertion messages. r=Standard8,mccr8

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dc00c2522dbf
https://hg.mozilla.org/mozilla-central/rev/682e4e9d330b
https://hg.mozilla.org/mozilla-central/rev/f58508d78613
https://hg.mozilla.org/mozilla-central/rev/61dea27fcb76
https://hg.mozilla.org/mozilla-central/rev/fba91011887a
https://hg.mozilla.org/mozilla-central/rev/203f8c5d9f76
https://hg.mozilla.org/mozilla-central/rev/0169ea0af1a5
https://hg.mozilla.org/mozilla-central/rev/da29f4ffde2e
https://hg.mozilla.org/mozilla-central/rev/eb2316c9dab1
https://hg.mozilla.org/mozilla-central/rev/e7af9adfb3d1
https://hg.mozilla.org/mozilla-central/rev/01cf5d247a96
https://hg.mozilla.org/mozilla-central/rev/a526034b8066
https://hg.mozilla.org/mozilla-central/rev/3fbe0dc36d32