1936189 - skip -moz-subtree-hidden-only-visually checks in content processes

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1936189. Only do -moz-subtree-hidden-only-visually checks in the parent process. r?#layout-reviewers

This is a chrome only css property (so it could still be used in a UA sheet that is applied to a content document) that was created solely to tabs/xul decks in a fashion that is more like the rest of css/html. And it still only has that single use in our tree. A UA sheet applying this property to content it doesn't control doesn't seem like it could be very useful.

Even those these checks are simple they are relatively costly because we check them on every frame and when we are traversing the frame tree (for display list building or setting a displayport) we are often memory bound, so pulling in another bit of otherwise cold memory for a rare style struct makes us wait for loading more memory and pushes more useful stuff out of caches. The parent process check remains very quick as verified by profiling.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f819082a015
Only do -moz-subtree-hidden-only-visually checks in the parent process. r=layout-reviewers,emilio

Comment 3

[amarc]

Backed out for causing reftest failures @ native-theme/470711-1.xhtml

• Backout link
• Push with failures
• Failure Log
• Failure line:

REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/native-theme/470711-1.xhtml == layout/reftests/native-theme/470711-1-ref.xhtml | image comparison, max difference: 200, number of differing pixels: 54

Comment 4

[Timothy Nikkel (:tnikkel)]

Neat, a reftest that loads via a chrome uri that uses a <tabpanels> element with appropriately hidden children.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:tnikkel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

seems some tests need to get updated.

Comment 7

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1936189. Move reftest layout/reftests/native-theme/470711-1.xhtml to be a browser chrome test. r?#layout-reviewers

As it uses chrome features that we only want to support in the parent process.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43ec74f53548
Move reftest layout/reftests/native-theme/470711-1.xhtml to be a browser chrome test. r=dshin
https://hg.mozilla.org/integration/autoland/rev/2a9f68224f6e
Only do -moz-subtree-hidden-only-visually checks in the parent process. r=layout-reviewers,emilio

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/43ec74f53548
https://hg.mozilla.org/mozilla-central/rev/2a9f68224f6e