1936204 - The text is scanned again if another string is copied while a warning text is canceled or a blocked dialog is confirmed

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: dlp_0.gif

Found in

• 135.0a1 (2024-12-09)

Affected versions

• 135.0a1 (2024-12-09)
• 134.0b8

Tested platforms

• Affected platforms: Windows 11, Windows 10
• Unaffected platforms:macOS 12, Ubuntu

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• DLP Agent is running

Steps to reproduce

1. Paste the warning string to Wikipedia.
2. While the scan is ongoing copy another random string.
3. Press cancel on the unsafe content window.

Expected result

• No scanning is performed.

Actual result

• The string from step 2 is scanned.

Regression range

• The issue happens after bug 1915351.

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1915351, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

It seems that this also happens with the blocked dialog.

Comment 3

[Greg Stoll :gstoll]

Attachment: Bug 1936204 - do not fallback to raw clipboard if snapshot doesn't have data r=#dlp-reviewers!,edgar

This was causing an issue where if the snapshot didn't have the appropriate
data because it was blocked by Content Analysis, it would fall back to
getting the data directly from the clipboard, which would trigger another
Content Analysis operation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:handyman, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4d7ed9a5599
do not fallback to raw clipboard if snapshot doesn't have data r=edgar,dlp-reviewers,handyman

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a4d7ed9a5599

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 136.0a1 (2025-01-13) on Windows 10x64 and Windows 11. The text is no longer scanned again if another string is copied while the scan in ongoing and the warning/ block message is displayed.