1936300 - Use distinct connection for watcher actors using a shared connection

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

Currently, debugging two contexts, like a tab, running in the same process from a remote debugging connection is deeply broken.
That's because we:

• use a single DevToolsServerConnection on the server side
• we end up spawning one watcher per context/tab
• the two watchers are using the same DevToolsServerConnection and same forwardingPrefix
• we end up with actors with the exact same actor ID, because they both use the same connection prefix
• DevToolsProcess{Parent/Child} is also confused and the internal #connections map is used by two distinct watchers, which is source of even more troubles.

This issue only impacts remote debugging, as local debugging spawns one client and server connection per debugged context/tab.
This is also limited to tab debugging, where the tab runs in the same process.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1936300 - [devtools] Fix remote debugging two tabs running in the same process.

The DevToolsProcess JS Process actor should better handle multiple instances
of watchers and will now have the to spawn their own DevToolsServerConnection,
with a new dedicated connection/forwarding prefix.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba8f27ea45d6
[devtools] Fix remote debugging two tabs running in the same process. r=devtools-reviewers,bomsy

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ba8f27ea45d6