1936370 - Fix the flex item's stretched cross-size when computing flex container's intrinsic inline size

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Bug 1742042 fixed the flex item's stretched cross-size when computing the flex container's intrinsic size. However, the code has two issues:

1. When getting the used align-self value for the flex item here, it fails to consider legacy -webkit-box-align value from the container.
2. When the flex item has box-sizing:border-box, it does not subtract the item's margin when computing the stretched cross-size. This is the logic to be fixed.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1936370 Part 1 - Fix legacy flex container cross size alignment when computing intrinsic inline size. r?dholbert

This patch extracts the logic from FlexItem's constructor that computes the
used align-self value of a flex item, with legacy -webkit-box-align
considered. The new helper is then used in ComputeIntrinsicISize().

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1936370 Part 2 - Fix flex item's stretched cross size with box-sizing:border-box when computing flex container's intrinsic inline size. r?dholbert

When the flex item has 'box-sizing:border-box', we should subtract its margin
from the stretched cross size.

The testcase is adapted from aspect-ratio-intrinsic-size-008.html, with
"box-sizing:border-box" added to the flex item.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1658b53c6682
Part 1 - Fix legacy flex container cross size alignment when computing intrinsic inline size. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c9a7242c12e3
Part 2 - Fix flex item's stretched cross size with box-sizing:border-box when computing flex container's intrinsic inline size. r=dholbert

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49665 for changes under testing/web-platform/tests

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1658b53c6682
https://hg.mozilla.org/mozilla-central/rev/c9a7242c12e3

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot