1936411 - Implement imperative popover invokers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Luke Warlow]

See https://github.com/whatwg/html/pull/10728 for details.

The showPopover() and togglePopover() methods now include an options bag that allows setting the popover invoker imperatively.

Comment 1

[Luke Warlow]

Attachment: Bug 1936411: Implement imperative popover invokers r?#dom-core,emilio

Comment 2

[Sebastian Zartner [:sebo]]

Once this lands, it needs to be documented. And it's also worth to be noted in the release notes, once it lands (not sure whether to already add the request for the addition, though).

Sebastian

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1169ad14ef5f
https://hg.mozilla.org/integration/autoland/rev/011876a25442
Implement imperative popover invokers r=emilio

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/011876a25442

Comment 5

[Hamish Willee]

FF141 MDN docs for this can be tracked in https://github.com/mdn/content/issues/40027

From Sebastian in https://bugzilla.mozilla.org/show_bug.cgi?id=1936411#c2

it needs to be documented. And it's also worth to be noted in the release note

The options are already documented in showPopover() and togglePopover(). They are also mentioned in the Other ways to set up a popover-invoker relationship in the Using the Popover API guide.

I think this is sufficient - were you expecting something else Sebastian?

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to Hamish Willee from comment #5)

I think this is sufficient - were you expecting something else Sebastian?

The existing documentation at showPopover() and togglePopover() looks complete, yes. I just meant, it needs to be added to the FF 141 release notes and to the BCD, which you're already tracking. So, thanks for that!

But I'll take the chance to add a release notes request. 😀

[Why is this notable]: Adds imperative ways to handle popovers.
[Affects Firefox for Android]: yes
[Suggested wording]: The HTMLElement.showPopover() and HTMLElement.togglePopover() methods now take an options.source argument referencing the popover invoker, and togglePopover() also takes a force resp. options.force argument to force the popover open or closed.
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/showPopover
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/togglePopover

Sebastian

Comment 7

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Note added to 141 beta release notes. I am keeping the relnote flag in the bug open until we ship to release. Thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Added to our 141 final release notes.