1936614 - The paste-to-create-attachment submits in-progress comment as file comment which isn't expected

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Pretty much every time I use the paste-to-create attachment feature I get bit by the same thing: It submits the in-progress comment.

Furthermore, the in-progress comment submitted isn't rendered as markdown, and so you get this awkward in progress comment of un-rendered text.

Would be nicer if it simply created the attachment, then put a markdown link at the cursor without submitting the comment.

Comment 1

[David Lawrence [:dkl]]

I am not able to reproduce this as I understand the issue. Can you give a more detailed step by step of what you are doing when this occurs? Maybe a screen shot as well? I will try to better reproduce it on my end. Thanks.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: this-is-a-yes-file-please-dont-submit-comment.txt

Ok, so the STR is something along the lines of the following (if this works, we should see this comment I am typing turned into an attachment with plain text description as the in-progress comment: 

1. Start writing a comment on a bug. 
2. Get some debug output you want to put on the comment; it's long enough that yeah, it makes sense to not paste directy in, but rather attach. For the purposes of this bug, I've tried `yes | head -n 100 | pbpaste` which puts 100 lines of `y` into the macOS paste buffer 
3. Paste into the comment window. You'll get a modal dialog (which I'll attach a screenshot of after) which says "cancel to paste normally, or give a file name". Give a filename. 
4. Tada: Now you have an attachment and your comment was submitted when you weren't expecting it.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

The comment text is also preserved in the comment box, which suggests something has maybe gone wrong here too.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Screenshot 2024-12-13 at 9.17.26 AM.png

This is the modal

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Screenshot 2024-12-13 at 9.17.42 AM.png

See how the comment was submitted, but the comment editor is still active with the contents of the submitted comment.

Comment 6

[David Lawrence [:dkl]]

Ok I see what you are doing now. I was doing it differently which explains why I couldn't reproduce. I think the solution to this with the least surprise to the user would be to just attach the pasted content and leave out the comment portion that is currently in the text area. Let me see when I could get to this. Probably not til the first of the year or more.

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

For sure. It's been like this for a long time, so no rush from me.

Comment 8

[Kohei Yoshino [:kohei]]

I’ll volunteer to take this since I implemented the feature. I think removing this line will solve the issue.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1936614 - The paste-to-create-attachment submits in-progress comment as file comment which isn't expected (#2506)

Comment 10

[BMO Github Automation]

Authored by https://github.com/kyoshino
https://github.com/mozilla-bteam/bmo/commit/93a1fc2b3a0c9bf44343846a6c50cf58664d3ef0
[master] Bug 1936614 - The paste-to-create-attachment submits in-progress comment as file comment which isn't expected