1936706 - Calendar printing: monthly grid - day of week is borked

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P1)

Description

[Stephen]

Attachment: Screenshot 2024-12-02 221931.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

Printing the calendar, can be reproduced all the time

Actual results:

Dates ( Mon - Sun ) do not line up with the correct numbers

Expected results:

see attached image

Comment 1

[Magnus Melin [:mkmelin] (away, back Aug 4)]

I see this. Seems my weeks show as starting on Tuesdays... And Sundays are not a thing?
Would assume bug 1917411 regressed this.

Comment 2

[Geoff Lankow (:darktrojan)]

It is indeed. Those weekday names changed from 1-indexed to 0-indexed, so we're off by one.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1936706 - Fix some L10n mistakes in calendar printing. r=#thunderbird-reviewers

I fixed the month grid weekday labels (an off-by-one error) and while making a test I noticed that
the document title on the same view was still constructed by mashing strings together, so I
changed that to use proper methods.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97d362ef521b
Fix some L10n mistakes in calendar printing. r=mkmelin

Comment 5

[Stephen]

So now the question is how do we get the fix?

Comment 6

[Magnus Melin [:mkmelin] (away, back Aug 4)]

It yet only fixed in daily development builds. After it's uplifted to beta (watch this bug) you can see it fixed in beta.