Closed
Bug 1936834
Opened 2 months ago
Closed 1 month ago
SmartBlock should use GetHost instead of DisplayHost
Categories
(Core :: Privacy: Anti-Tracking, defect, P3)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: edgul, Assigned: wwen)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
DisplayHost is ideally used for creating human-readable strings for user display purposes. URLs that are used for logic should probably be using GetHost or similar.
I'm not sure if all of these uses fall under the same component, but these uses of displayHost should be updated to use getHost:
- https://searchfox.org/mozilla-central/rev/7fb746f0be47ce0135af7bca9fffdb5cd1c4b1d5/browser/extensions/webcompat/experiment-apis/trackingProtection.js#191
- https://searchfox.org/mozilla-central/rev/7fb746f0be47ce0135af7bca9fffdb5cd1c4b1d5/browser/extensions/webcompat/experiment-apis/trackingProtection.js#207
- https://searchfox.org/mozilla-central/rev/7fb746f0be47ce0135af7bca9fffdb5cd1c4b1d5/mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/experiment-apis/trackingProtection.js#191
- https://searchfox.org/mozilla-central/rev/7fb746f0be47ce0135af7bca9fffdb5cd1c4b1d5/mobile/android/android-components/components/feature/webcompat/src/main/assets/extensions/webcompat/experiment-apis/trackingProtection.js#207
Thanks!
Assignee | ||
Updated•2 months ago
|
Assignee: nobody → wwen
Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Component: Privacy: Anti-Tracking → Tooling & Investigations
Product: Core → Web Compatibility
Updated•2 months ago
|
Component: Tooling & Investigations → Privacy: Anti-Tracking
Product: Web Compatibility → Core
Assignee | ||
Updated•2 months ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by wwen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ec469c601b
Use host instead of displayHost for smartblock logic. r=edgul,twisniewski
Comment 3•1 month ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•