1936874 - EventsDispatcher should retrieve browsing contexts via BrowsingContext.get

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Julian Descottes [:jdescottes]]

EventsDispatcher unnecessarily uses TabManager.getBrowsingContextById today. All the context ids found in events' contextInfo should be platform browsing context ids, and not TabManager UUIDs. Therefore we don't need the overhead of getBrowsingContextById. Also will unblock Bug 1761445

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1936874 - [remote] EventsDispatcher should retrieve browsing contexts via BrowsingContext.get

All context ids handled by the events dispatcher are actual browsing context ids and not
TabManager UUIDs, there is no reason to use getBrowsingContextById here.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:jdescottes, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Julian, can you please check why we didn't land this patch?

Comment 4

[Julian Descottes [:jdescottes]]

Let's rebase and do a try push, I don't remember why this didn't land.
https://treeherder.mozilla.org/jobs?repo=try&revision=a8b06370eb2aa82bef10b6193665caf9e4600578
Try looks green I'll land this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/443b0f786a62
[remote] EventsDispatcher should retrieve browsing contexts via BrowsingContext.get r=webdriver-reviewers,whimboo

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/443b0f786a62