1936950 - [wpt-sync] Sync PR 49670 - [Masonry] Introduce parsing for masonry-fill.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49670 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49670
Details from upstream follow.

Celeste Pan <[e-mail]> wrote:

[Masonry] Introduce parsing for masonry-fill.

This CL introduces the parsing for the CSS property masonry-fill.

This is part of: https://chromestatus.com/feature/5149560434589696

The properties are behind the CSSMasonryLayout feature flag. The spec definition for masonry-fill can be found here: https://tabatkins.github.io/specs/css-masonry/#masonry-fill.

Bug: 343257585
Change-Id: Iaec9a23dce2a2117c84cd40d096b7edc69248e37

Reviewed-on: https://chromium-review.googlesource.com/6089846
WPT-Export-Revision: 120e310ba6ef5c58d1b5d89c9ba3e1db8b02914b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ad7b5287f02ca92b67817ab3738816c378ca593

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 2 subtests

Status Summary

Firefox

OK : 3
PASS: 5
FAIL: 4

Chrome

OK : 3
PASS: 5
FAIL: 4

Safari

OK : 3
PASS: 5
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-masonry/tentative/parsing/masonry-fill-computed.html [wpt.fyi]
  • Property masonry-fill value 'normal': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property masonry-fill value 'reverse': FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-masonry/tentative/parsing/masonry-fill-valid.html [wpt.fyi]
  • e.style['masonry-fill'] = "normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['masonry-fill'] = "reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b7e45e8e54c
[wpt PR 49670] - [Masonry] Introduce parsing for masonry-fill., a=testonly
https://hg.mozilla.org/integration/autoland/rev/f382199c5f64
[wpt PR 49670] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6b7e45e8e54c
https://hg.mozilla.org/mozilla-central/rev/f382199c5f64