1937016 - Race condition in "input.performActions" because of missing await keyword for "#finalizeAction()"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I noticed a race condition when investigating bug 1936804. Here we do not use await for the call to #finalizeAction, which is async. As such the input.releaseActions command returns too early and can cause side-effects with other action commands.

Maybe it's even causing the issue on bug 1936804 (and others).

12-12 22:02:38.866  3444  3459 I Gecko   : 1734040958866	RemoteAgent	DEBUG	WebDriverBiDiConnection a4ffffdc-93d3-4043-9d4b-0d695a2141ec -> {"id":7,"method":"input.releaseActions","params":{"context":"0313f1cc-76a2-4793-9349-e75d2a44c384"}}
12-12 22:02:38.866  3444  3459 I Gecko   : 1734040958866	RemoteAgent	TRACE	Received command input.releaseActions for destination ROOT
12-12 22:02:38.868  3444  3459 I Gecko   : 1734040958868	RemoteAgent	DEBUG	WebDriverBiDiConnection a4ffffdc-93d3-4043-9d4b-0d695a2141ec <- {"type":"success","id":7,"result":{}}
12-12 22:02:38.874  3444  3459 I Gecko   : 1734040958874	RemoteAgent	DEBUG	WebDriverBiDiConnection a4ffffdc-93d3-4043-9d4b-0d695a2141ec closed
12-12 22:02:38.879  3444  3459 I Gecko   : 1734040958878	Marionette	DEBUG	0 -> [0,2,"WebDriver:SetTimeouts",{"implicit":0}]
12-12 22:02:38.880  3444  3459 I Gecko   : 1734040958880	Marionette	DEBUG	0 <- [1,2,null,{"value":null}]
12-12 22:02:38.887  3476  3492 I Gecko   : 1734040958887	RemoteAgent	TRACE	Created MessageHandler WINDOW_GLOBAL for session e8f35057-69bf-4ed6-9c96-c262ccb72cda
12-12 22:02:38.887  3476  3492 I Gecko   : 1734040958887	RemoteAgent	TRACE	Received command input._finalizeAction for destination WINDOW_GLOBAL
12-12 22:02:38.888  3444  3459 I Gecko   : 1734040958888	Marionette	DEBUG	0 -> [0,3,"WebDriver:SetTimeouts",{"pageLoad":300000}]
12-12 22:02:38.890  3444  3459 I Gecko   : 1734040958890	Marionette	DEBUG	0 <- [1,3,null,{"value":null}]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1937016 - [webdriver-bidi] Fix race condition in "input.releaseActions".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02288e1a162b
[webdriver-bidi] Fix race condition in "input.releaseActions". r=webdriver-reviewers,Sasha

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/02288e1a162b