1937118 - AnimationFramePromise hangs when window gets navigated

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Noticed while investigating the issue over on bug 1936804. In our input.performActions implementation for WebDriver BiDi we use the AnimationFramePromise in the content process. This worked fine so far but when an action actually triggers a navigation of the current navigable the formerly registered callback for requestAnimationFrame will no longer be called because the window gets replaced.

Instead of checking window.close only we should switch to EventPromise and wait for the unload event of the window to escape and not hang forever.

The changes that I'm going to upload soon will fix the problem on bug 1936804 for nofis and nofis-ship jobs that we run by default in CI now.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1937118 - [remote] Replace window.closed check with "pagehide" event in AnimationFramePromise.

This patch modifies the AnimationFramePromise function to use
an unload event listener for aborting the promise instead of
repeatedly polling win.closed.

This approach simplifies the logic, avoids reliance on polling,
and fixes a hang issue that occurred when the window was navigated.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/584a4cf92e9c
[remote] Replace window.closed check with "pagehide" event in AnimationFramePromise. r=webdriver-reviewers,Sasha

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/584a4cf92e9c