1937136 - Http Exceptionality preferences should be enabled by scotchbonnet pref

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• Nightly 134.0b9;

Affected versions

• 134.0b9
• most likely 135.0b as well

Tested platforms

• Affected platforms: Windows 11, Mac 13, Ubuntu 24

Steps to reproduce

1. Open 134 beta version (nightly135 has different default preferences for this area, but we're assuming these preferences should be controlled by browser.urlbar.scotchBonnet.enableOverride)
2. Navigate to about:config, flip browser.urlbar.scotchBonnet.enableOverride to true, restarting the browser.
3. Navigate to about:config and check values for the following preferences:

• browser.urlbar.trimURLs
• browser.urlbar.trimHttps
• browser.urlbar.untrimOnUserInteraction.featureGate
• dom.security.https_first_schemeless
• Dom.security.https_first
• security.insecure_connection_text.enabled

Expected result

• browser.urlbar.trimURLs true
• browser.urlbar.trimHttps true
• browser.urlbar.untrimOnUserInteraction.featureGate true
• dom.security.https_first_schemeless true
• Dom.security.https_first false
• security.insecure_connection_text.enabled true

Actual result

• browser.urlbar.trimURLs
• browser.urlbar.trimHttps false
• browser.urlbar.untrimOnUserInteraction.featureGate false
• dom.security.https_first_schemeless true
• Dom.security.https_first false
• security.insecure_connection_text.enabled false

Regression range

• N/A

Comment 1

[Dale Harvey (:daleharvey)]

To be clear, setting scotchBonnet.enableOverride will not override the value of the pref in about:config, features such as secondaryActions.featureGate will still report false by default, it will only affect when those prefs are read via getScotchBonnetPref

Hower since Marco picked this up I am guessing that some of the prefs that we consider probably should be enabled via getScotchBonnetPref probably arent?

Comment 2

[Marco Bonardo [:mak]]

browser.urlbar.untrimOnUserInteraction.featureGate is enabled with scotchBonnet ovverride pref, also dom.security.https_first_schemeless has been released in Firefox 129.
That leaves us with security.insecure_connection_text.enabled and I'm thinking to just enable it in Nightly and uplift to 135. Shouldn't be controversial, it will just be a bit redundant to show both http and the label without Scotch Bonnet, but shouldn't break any workflow.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1937136 - Show the not-secure label in the address bar for http. r=jteow

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1937136 - Let address bar trimHttps and untrim just be controlled by the ScotchBonnet override. r=jteow

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801d9915c8f2
Show the not-secure label in the address bar for http. r=jteow
https://hg.mozilla.org/integration/autoland/rev/13fc90c67204
Let address bar trimHttps and untrim just be controlled by the ScotchBonnet override. r=jteow

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/801d9915c8f2
https://hg.mozilla.org/mozilla-central/rev/13fc90c67204

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Marco Bonardo [:mak]]

wontfxing 135 as Scotch Bonnet has been rescheduled to 136, and the not-secure label is not considered critical for Beta testing.

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on Firefox 135.0 on Windows 10.
Verified as fixed on Firefox Nightly 137.0a1 and Firefox 136.0b9 on Windows 10, Ubuntu 22, macOS 14.