1937160 - [wpt-sync] Sync PR 49681 - Make closeWatcher.requestClose() not require user activation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49681 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49681
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Make closeWatcher.requestClose() not require user activation

Per the conversation here:

https://github.com/openui/open-ui/issues/1128#issuecomment-2539519339

There's a desire to ship closeWatcher.requestClose() along with
dialog.requestclose() both not requiring user activation.

The spec PR has been updated accordingly:
https://github.com/whatwg/html/pull/10737

(in this commit:
https://github.com/whatwg/html/pull/10737/commits/76619aa99f37cef85be93ff98fadd03284347008)

Fixed: 383593252
Change-Id: I8c05e352d8b4964407a1cee36f35372e192e2ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092173
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: David Baron \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1396007}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e5acaa6e729f90d79a279aad03edf7a1866ed04

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 13

Chrome

OK : 2
PASS: 8
FAIL: 5

Safari

OK : 2
FAIL: 13

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /close-watcher/basic.html [wpt.fyi]
  • requestClose() with no user activation: FAIL (Chrome: FAIL, Safari: FAIL)
  • destroy() then requestClose(): FAIL (Chrome: PASS, Safari: FAIL)
  • close() then requestClose(): FAIL (Chrome: PASS, Safari: FAIL)
  • requestClose() then destroy(): FAIL (Chrome: FAIL, Safari: FAIL)
  • close() then destroy(): FAIL (Chrome: PASS, Safari: FAIL)
  • destroy() then close request: FAIL (Chrome: PASS, Safari: FAIL)
  • Close request then destroy(): FAIL (Chrome: PASS, Safari: FAIL)
• /close-watcher/inside-event-listeners.html [wpt.fyi]
  • destroy() inside oncancel: FAIL (Chrome: PASS, Safari: FAIL)
  • destroy() inside onclose: FAIL (Chrome: FAIL, Safari: FAIL)
  • close() inside oncancel: FAIL (Chrome: PASS, Safari: FAIL)
  • close() inside onclose: FAIL (Chrome: FAIL, Safari: FAIL)
  • requestClose() inside oncancel: FAIL (Chrome: PASS, Safari: FAIL)
  • requestClose() inside onclose: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c689e198a666
[wpt PR 49681] - Make closeWatcher.requestClose() not require user activation, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c689e198a666