1937284 - [wpt-sync] Sync PR 49695 - [flex] Break all items into flex-lines upfront.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49695 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49695
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[flex] Break all items into flex-lines upfront.

Previously we'd break items into flex-lines, line-by-line.

This meant that we'd never correctly compute the
"main_axis_inner_size" for column wrapped flex-lines (as you need
to calculate the max_sum_hypothetical_main_size, vs. just the
sum_hypothetical_main_size for the individual line.

This patch breaks items into flex-lines all in one pass. This means
that we can correctly determine the space to flex into fixing
justify-content-007.

Additionally adds a couple of tests for the flexing broken case.

After this patch we can now (relatively) easily add balancing.

Fixed: 40777433
Change-Id: I588adc16d6c066eeb925380f93ef8695a6211317
Reviewed-on: https://chromium-review.googlesource.com/6093961
WPT-Export-Revision: 515421c164b6984a1e35a564ec169ff47aab5573

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e0be0d2953f87aaad6d2a3be89af2cf06ab06c7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=518920a6c58a7ff5fababee096c91dcd0de63607

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de381341fb93
[wpt PR 49695] - [flex] Break all items into flex-lines upfront., a=testonly

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/de381341fb93