Move replaceVars helper into menu-manager.js for cZ
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
2.58 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
The only caller for the replaceVars helper is in menu-manager.js so move the helper into that file.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Comment 2•8 months ago
•
|
||
Comment on attachment 9443692 [details] [diff] [review]
1937379-irc-menus-replaceVars-25321.patch
lgtm. Comment formatting is all over the place in menu-manager.js. I would probably have kept the double slash for 1 or two liners at least for function descriptions.
|
|
||
Updated•8 months ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/cebe41dfee02
Move replaceVars helper into menu-manager.js for cZ. r=frg
|
|
||
Comment 4•2 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/1ccbdef7df27580ab68cbf8e19b81e29b9aeb6ba
Move replaceVars helper into menu-manager.js for cZ. r=frg a=frg
Description
•