Tidy up dumpObjectTree helper in cZ
Categories
(SeaMonkey :: Chat, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file, 1 obsolete file)
|
3.83 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
The compress argument for dumpObjectTree is always undefined/true so can be removed meaning the helper can be tidied, also make use of String repeat method.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Comment 2•8 months ago
|
||
Comment on attachment 9443694 [details] [diff] [review]
1937381-irc-tidy-dumpObjectTree-25321.patch
NIT recurse and level are currently not set in any call. Theoretically they could be removed too. recurse is used as a boolean in the comparision and value / bounds are not checked. I think this should be changed to recurse > 0 as a minimum check. Could not be undefined because it is set in the function to 0 in this case.
s could be a let too I think but that is nit-picking :) In the event of recursion different s are allocated and returned in the global scope.
r/a+ with this fixed.
if ((i != "parent") && (recurse))
s += dumpObjectTree (o[i], recurse - 1,compress, level + 1);
s += dumpObjectTree(o[i], recurse - 1, level + 1);
Remove unused recurse and level
|
|
||
Comment 4•8 months ago
|
||
Comment on attachment 9466003 [details] [diff] [review]
1937381-irc-tidy-dumpObjectTree-v1_1-25321.patch
LGTM r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/de9480d08b92
Tidy up dumpObjectTree helper in cZ. r=frg
|
|
||
Comment 6•1 month ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c40569b978bc86c990a647cf89e2dd778824df11
Tidy up dumpObjectTree helper in cZ. r=frg a=frg
Description
•