1937387 - Fix makeLogName helper to not encode twice in prefs.js in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

At the moment the encode function in makeLogName helper encodes twice and can also generate strange results, for example with a channel called "SM:dev" the current code creates a log name "SM%253adev" whereas "SM%3Adev" should be sufficient.

Comment 1

[Ian Neal]

Attachment: 1937387-irc-fix-makeLogName-25321.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1937387-irc-fix-makeLogName-v1_1-25321.patch

Force output to be lowercase

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9443705 [details] [diff] [review]
1937387-irc-fix-makeLogName-v1_1-25321.patch

LGTM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29029210b45f
Fix makeLogName helper to not encode twice in prefs.js in cZ. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a5e4e9a42028876106c186c62053829e0ee55bff
Fix makeLogName helper to not encode twice in prefs.js in cZ. r=frg a=frg