Add helper to file-utils.js for ensuring an nsIFile is returned in cZ
Categories
(SeaMonkey :: Chat, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
4.51 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment there's duplicated for checking whether an argument is a string or nsIFile and if a string creating an nsIFile from it.
Makes sense to add a helper to file-utils.js that removes this minor duplication
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Updated•7 months ago
|
|
|
||
Comment 2•7 months ago
|
||
Comment on attachment 9443711 [details] [diff] [review]
1937397-irc-returnFile-25321.patch
lgtm r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/81f79888d25e
Add helper to file-utils.js for ensuring an nsIFile is returned in cZ. r=frg DONTBUILD
|
|
||
Comment 4•1 month ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4179b8b9ccf0f1d8ce3277b66669c160515318f1
Add helper to file-utils.js for ensuring an nsIFile is returned in cZ. r=frg a=frg
Description
•