1937411 - [wpt-sync] Sync PR 49698 - wpt: Fix flakiness in `vh_not_refreshing_on_chrome.html`

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49698 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49698
Details from upstream follow.

Martin Robinson <[e-mail]> wrote:

wpt: Fix flakiness in vh_not_refreshing_on_chrome.html

This test manually animates the height of an <iframe> that has content
which uses the vh unit. Each tick of the animation changes the height
by one pixel. Inside the <iframe> the element using vh units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves vh_not_refreshing_on_chrome.html to remove
flakiness by making the test wait to start until after the <iframe> has
loaded and to increase the <iframe> height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

It still times out, but that will be fixed in an upcoming change to
increase the consistency of <iframe> sizing.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes #<!-- nolink -->23385.
Fixes #<!-- nolink -->15570.

Signed-off-by: Martin Robinson <[e-mail]>

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#34626

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9d30edc4721b3632b41fecfc31c08a105e7bdd8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d16bc2941b32
[wpt PR 49698] - wpt: Fix flakiness in `vh_not_refreshing_on_chrome.html`, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d16bc2941b32