1937427 - [wpt-sync] Sync PR 49699 - [SRI Message Signatures] Serialize component parameters.

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49699 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49699
Details from upstream follow.

Mike West <[e-mail]> wrote:

[SRI Message Signatures] Serialize component parameters.

In the signature base, we should be serializing components' parameters
along with the component name. That is, we're currently serializing the
component list ("identity-digest";sf) as
"identity-digest": [header contents go here]\n. We should be
serializing it with the sf parameter, as
"identity-digest";sf: [header contents go here]\n.

This CL addresses that mistake, and updates test signatures accordingly.

Bug: 383661619
Change-Id: Iebaf6d40eb5a49d7e395524182d09ac0f9205b69
Reviewed-on: https://chromium-review.googlesource.com/6088162
WPT-Export-Revision: 0549a06a2ffdbebb8a952a54f3da15b32155cf3e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6b6e40f0c13a02c2b7d3ba4efab46509cf53e7c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 14 subtests

Status Summary

Firefox

OK : 3
PASS : 29
FAIL : 24
ERROR: 1

Chrome

OK : 4
PASS : 41
FAIL : 12

Safari

OK : 3
PASS : 29
FAIL : 24
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /subresource-integrity/signatures/tentative/fetch.any.sharedworker.html [wpt.fyi]
  • No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/fetch.any.html [wpt.fyi]
  • No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/fetch.any.worker.html [wpt.fyi]
  • No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/script.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • No signature, valid integrity check: loads.: FAIL (Chrome: PASS, Safari: FAIL)
  • Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • Valid signatures, integrity check matches neither: blocked.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3b2ee3645b
[wpt PR 49699] - [SRI Message Signatures] Serialize component parameters., a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ed3b2ee3645b