1937593 - [Toolbar redesign] Clean up toolbar telemetry to use old telemetry during landscape mode.

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[[:skhan]]

It was decided that we probably don’t need new telemetry for all items of landscape mode of Navigation bar since we are essentially using the same menu and Tab counter (home screen and browser screen) on address bar toolbar. Because in foresight, we wouldn’t need to remove any telemetry and continue having the ones we have.
But we will be adding new telemetry for new items such as back, forward, open in fenix (since they moved from menu items to toolbar items), and new tab (Landscape mode)
Portrait mode (or one with two toolbars) will always have telemetry for all the items since Navigation bar is a complete new feature.

Comment 1

[[:skhan]]

Attachment: Bug 1937593 - Update telemetry for navigation bar landscape mode

Comment 2

[[:skhan]]

Telemetry now for all scenarios:
HomeScreen

onTabsButtonClick = {
    NavigationBar.homeTabTrayTapped.record(NoExtras()) //Navigation Bar Portrait mode (or two toolbar mode)
    StartOnHome.openTabsTray.record(NoExtras()) //Navigation Bar landscape mode and old toolbar
}
onTabsButtonLongPress = {
    NavigationBar.homeTabTrayLongTapped.record(NoExtras()) //Navigation Bar Portrait mode (or two toolbar mode)
    StartOnHome.longClickTabsTray.record(NoExtras()) //Navigation Bar landscape mode and old toolbar
},
onSearchButtonClick = {
    NavigationBar.homeSearchTapped.record(NoExtras()) //Navigation Bar Portrait mode. Not available in landscape or old toolbar
}
onMenuButtonClick = {
    NavigationBar.homeMenuTapped.record(NoExtras()) //Navigation Bar Portrait mode. With old menu and new menu
    Events.toolbarMenuVisible.record(NoExtras())  //Navigation Bar landscape mode and old toolbar. With old and new menu.
}

BrowserScreen
_The browserscreen also supports existing telemetry on navbar clicks. The Events one are the existing ones and on landscape modes while the NavigationBar are the new ones.
_

onBackButtonClick = {
    NavigationBar.browserBackTapped.record(NoExtras()) //Navigation Bar Portrait mode (or two toolbar mode)
    Events.browserToolbarAction.record(Events.BrowserMenuActionExtra("back")) //Navigation bar landscape mode
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("back")) // old toolbar when back button is in menu
}
onBackButtonLongPress = {
    NavigationBar.browserBackLongTapped.record(NoExtras()) /Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserMenuActionExtra("back_long_press")) //Navigation bar landscape mode
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("back_long_press")) // old toolbar when back button is in menu

}
onForwardButtonClick = {
    NavigationBar.browserForwardTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserMenuActionExtra("forward")) //Navigation bar landscape mode
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("forward")) // old toolbar when forward button is in menu
}
onForwardButtonLongPress = {
    NavigationBar.browserForwardLongTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserMenuActionExtra("forward_long_press")) //Navigation bar landscape mode
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("forward_long_press")) // old toolbar when forward button is in menu
}
onTabsButtonClick = {
    NavigationBar.browserTabTrayTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("tabs_tray")) //Navigation Bar landscape mode and old toolbar
},
onTabsButtonLongPress = {
    NavigationBar.browserTabTrayLongTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("tabs_tray_long_press")) //Navigation Bar landscape mode and old toolbar
},
onNewTabButtonClick = {
    NavigationBar.browserNewTabTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("new_tab")) //Navigation Bar landscape mode. Not available for old toolbar
}
onNewTabButtonLongPress = {
    NavigationBar.browserNewTabLongTapped.record(NoExtras()) //Navigation Bar Portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("new_tab_long_press")) //Navigation Bar landscape mode. Not available for old toolbar
}
onMenuButtonClick = {
    NavigationBar.browserMenuTapped.record(NoExtras()) //Navigation Bar Portrait mode. With old menu and new menu.
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("menu_press")) //Navigation bar landscape mode.
    Events.toolbarMenuVisible.record(NoExtras())  //Old toolbar.
}

CustomTab

onBackButtonClick = {
    NavigationBar.customBackTapped.record(NoExtras()) /Navigation Bar in portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("custom_back")) //Navigation bar in landscape mode.
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("back")) //Old toolbar when back button is in menu.
},
onBackButtonLongPress = {
    NavigationBar.customBackLongTapped.record(NoExtras()) //Navigation Bar in portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("custom_back_long_press")) //Navigation bar in landscape mode.
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("back_long_press")) //Old toolbar when back button is in menu.
},
onForwardButtonClick = {
    NavigationBar.customForwardTapped.record(NoExtras()) //Navigation Bar in portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("custom_forward")) /Navigation bar in landscape mode.
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("forward")) //Old toolbar when forward button is in menu.
},
onForwardButtonLongPress = {
    NavigationBar.customForwardLongTapped.record(NoExtras()) //Navigation Bar in portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("custom_back_long_press")) /Navigation bar in landscape mode.
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("forward_long_press")) //Old toolbar when forward button is in menu.
},
onOpenInBrowserButtonClick = {
    NavigationBar.customOpenInFenixTapped.record(NoExtras()) //Navigation Bar in portrait mode
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("open_in_fenix"))  //Navigation bar in landscape mode.
    Events.browserMenuAction.record(Events.BrowserMenuActionExtra("open_in_fenix")) //Old toolbar when open in fenix button is in menu.
}
onMenuButtonClick = {
    NavigationBar.customMenuTapped.record(NoExtras()) //Navigation Bar Portrait mode. With old menu and new menu.
    Events.browserToolbarAction.record(Events.BrowserToolbarActionExtra("menu_press")) //Navigation bar landscape mode.
    Events.toolbarMenuVisible.record(NoExtras())  //Old toolbar.
}

cc [:dpop]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63d968113f77
Update telemetry for navigation bar landscape mode r=android-reviewers,Roger

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/63d968113f77