193770 - alignment not applied on already aligned line

Status: NEW

(Core :: DOM: Editor, defect, P3)

Description

[Charles Rosendahl]

If you change the text justification on one line in a block of text, then move 
it back, then try to justify the entire block of text, it doesn't change the 
line you'd changed earlier.

Steps to Reproduce:
===================
1.  Open the Compose window.
2.  Enter two lines of text.
3.  Place your cursor on one of the lines of text.
4.  Press the icon that centers the text.
5.  Press the icon that left justifies the text.
6.  Select the enter block of text
7.  Press the icon that centers the text
The line you'd centered earlier is not changed.

Comment 1

[Kathleen :Brade]

This is a duplicate bug...

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

taking

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 4

[Kathleen :Brade]

Comment on attachment 114787 [details] [diff] [review]
fix #1

r=brade

Comment 5

[Kathleen :Brade]

Comment on attachment 114787 [details] [diff] [review]
fix #1

OK, so there is a problem with the JoinNodes block.  The first line changed is
fine but the JoinNodes call can mess up if there are multiple attributes on the
div (such as indent or color or other style)

Comment 6

[Joe Francis]

I distinctly remember making this same fix, and now I can't find it anywhere. 

The div merging isn't going to work.  The divs may have incompatible attributes.
 For example, in css editing, we do indention via divs with attributes.  You may
end up merging divs with differing indention this way, which will either casue
unwanted indention, or lose wanted indention.

r= on just the one line change to the Alignblock call, though.

Comment 7

[Joe Francis]

snarfing bug

Comment 8

[Joe Francis]

Attachment: patch#2

just the simple param change to the AlignBlock call.  brade, kin, r/sr?

Comment 9

[Kathleen :Brade]

Comment on attachment 116622 [details] [diff] [review]
patch#2

r=brade

Comment 10

[kinmoz]

Comment on attachment 116622 [details] [diff] [review]
patch#2

sr=[e-mail]

Comment 11

[Makoto Kato [:m_kato]]

old bug.  down to P3