Closed Bug 1937731 Opened 2 months ago Closed 2 months ago

GMPParent can crash during shutdown in debug builds

Categories

(Core :: Audio/Video: GMP, defect, P2)

defect

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 obsolete file)

The problem is MOZ_ASSERT(GMPEventTarget()->IsOnCurrentThread()); which is almost everywhere in GMPParent.cpp. Once shutdown has started, GeckoMediaPluginService::GetThread returns nullptr, leading to GMPEventTarget() returning nullptr, and IsOnCurrentThread() on a nullptr target will crash.

Blocks: 1937908
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d75ea9fa6cda Don't crash when checking if on GMP event target while in shutdown. r=aosmond,media-playback-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Attachment #9444021 - Attachment is obsolete: true
Component: WebRTC: Audio/Video → Audio/Video: GMP
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: