Closed Bug 1937815 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 49730 - [css-properties-values-api] Test unit arithmetic separately

Tracking

()

Status:

RESOLVED FIXED

Milestone:

135 Branch

Tracking Flags:

Tracking

Status

firefox135

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 months ago

Sync web-platform-tests PR 49730 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49730
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[css-properties-values-api] Test unit arithmetic separately

A subtest relying on unit arithmetic snuck into one of the WPTs
covered by the "Custom Properties" focus area of Interop 2024.
As unit arithmetic is not covered by Interop 2024, the default
resolution to this problem is to remove the whole file from Interop [1].

However, in this case, it's relatively easy and harmless to move
the offending test to a separate file.

[1] https://github.com/web-platform-tests/interop/issues/604

Change-Id: Ic444d07288c2c8bb54595c61813d0217b3cc1032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097816
Reviewed-by: Daniil Sakhapov \<sakhapov@chromium.org>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397239}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=afe5e0a67dc43735bcafb3c9e82462832da42d10

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 78 tests and 16 subtests

Status Summary

Firefox

OK : 72[Gecko-linux1804-64-qr-debug] 77[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
PASS : 732
FAIL : 27
ERROR: 1

Chrome

OK : 78
PASS : 1044
FAIL : 39

Safari

OK : 78
PASS : 1074
FAIL : 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-properties-values-api/animation/custom-property-animation-transform-none.tentative.html [wpt.fyi]
- Animating a custom property of type "<transform-list>|none" from "none" to <transform-list> value: FAIL linked bug:Bug 1861408
- Animating a custom property of type "<transform-function>|none" from "none" to <transform-function> value: FAIL linked bug:Bug 1861408
/css/css-properties-values-api/animation/custom-property-transition-transform-function-none.tentative.html [wpt.fyi]
- A custom property keyword none is not a <transform-function> value and is not interpolable with <transform-function> values: FAIL linked bug:Bug 1861408
/css/css-properties-values-api/animation/custom-property-transition-transform-function-to-list.html [wpt.fyi]
- A custom property cannot yield a CSS Transition from <transform-function> to <transform-list>: FAIL linked bug:Bug 1861408
/css/css-properties-values-api/animation/custom-property-transition-transform-list-none.tentative.html [wpt.fyi]
- A custom property keyword none is not a <transform-list> value and is not interpolable with <transform-list> values: FAIL linked bug:Bug 1861408
/css/css-properties-values-api/at-property-animation.html [wpt.fyi]
- CSS animation setting "inherit" for a custom property on a keyframe is responsive to changing that custom property on the parent.: FAIL linked bug:Bug 1870370
- JS-originated animation setting "inherit" for a custom property on a keyframe is responsive to changing that custom property on the parent.: FAIL linked bug:Bug 1870370
/css/css-properties-values-api/at-property-typedom.html [wpt.fyi]
- Properties declared with @property reify correctly: FAIL linked bug:Bug 1634457
- Re-declaring a property with a different type affects reification: FAIL linked bug:Bug 1634457
/css/css-properties-values-api/register-property-syntax-parsing.html [wpt.fyi]
- syntax:'<number>', initialValue:'calc(15 + (sign(100vh - 10px) * 5))' is valid: FAIL linked bug:Bug 1915981
- syntax:'<integer>', initialValue:'calc(15 + (sign(100vh - 10px) * 5))' is valid: FAIL linked bug:Bug 1915981
- syntax:'<angle>', initialValue:'calc(15deg + (sign(100vh - 10px) * 5deg))' is valid: FAIL linked bug:Bug 1915981
- syntax:'<time>', initialValue:'calc(15s + (sign(100vh - 10px) * 5s))' is valid: FAIL linked bug:Bug 1915981
- syntax:'<resolution>', initialValue:'calc(15dppx + (sign(100vh - 10px) * 5dpi))' is valid: FAIL linked bug:Bug 1915981
/css/css-properties-values-api/typedom.html [wpt.fyi]: ERROR linked bug:Bug 1634362
- Computed * is reified as CSSUnparsedValue: FAIL linked bug:Bug 1634362

New Tests That Don't Pass

/css/css-properties-values-api/animation/custom-property-animation-length-percentage-comma-list.html [wpt.fyi]
- Animating a custom property of type <length-percentage># with iterationComposite: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-animation-length-percentage-space-list.html [wpt.fyi]
- Animating a custom property of type <length-percentage>+ with iterationComposite: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-animation-resolution-comma-list.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-animation-resolution-space-list.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-animation-transform-function.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
- Animating a custom property of type <transform-function> with additivity: FAIL (Chrome: FAIL, Safari: PASS)
- Animating a custom property of type <transform-function> with a single keyframe and additivity: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-animation-transform-list-multiple-values.html [wpt.fyi]
- Animating a custom property of type <transform-list> containing multiple values with iterationComposite: FAIL (Chrome: FAIL, Safari: PASS)
- Animating a custom property of type <transform-list> containing multiple values and with mismatching list lengths: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-animation-transform-none.tentative.html [wpt.fyi]
- Animating a custom property of type "<transform-list>|none" from "none" to <transform-list> value: FAIL (Chrome: PASS, Safari: PASS)
- Animating a custom property of type "<transform-function>|none" from "none" to <transform-function> value: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-transition-non-inherited-used-by-standard-property.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-transition-percentage.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-transition-property-all.html [wpt.fyi]
- A custom property can yield a CSS Transition with transition-property: all: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-transition-transform-function-box-size.tentative.html [wpt.fyi]
- A custom property of type <transform-function> yields a CSS Transition using the mix function for a box size dependent matrix interpolation: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-properties-values-api/animation/custom-property-transition-transform-function-none.tentative.html [wpt.fyi]
- A custom property keyword none is not a <transform-function> value and is not interpolable with <transform-function> values: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-transition-transform-function-to-list.html [wpt.fyi]
- A custom property cannot yield a CSS Transition from <transform-function> to <transform-list>: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/animation/custom-property-transition-transform-list-box-size.tentative.html [wpt.fyi]
- A custom property of type <transform-list> yields a CSS Transition using the mix function for a box size dependent matrix interpolation: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-properties-values-api/animation/custom-property-transition-transform-list-none.tentative.html [wpt.fyi]
- A custom property keyword none is not a <transform-list> value and is not interpolable with <transform-list> values: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/at-property-animation.html [wpt.fyi]
- CSS animation setting "inherit" for a custom property on a keyframe is responsive to changing that custom property on the parent.: FAIL (Chrome: PASS, Safari: PASS)
- JS-originated animation setting "inherit" for a custom property on a keyframe is responsive to changing that custom property on the parent.: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/at-property-shadow.html [wpt.fyi]
- @property rules in shadow trees should be globally registered: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-properties-values-api/at-property-typedom.html [wpt.fyi]
- Properties declared with @property reify correctly: FAIL (Chrome: PASS, Safari: PASS)
- Re-declaring a property with a different type affects reification: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/initial-value-unit-arithmetic.html [wpt.fyi]
- syntax:'<length>', initialValue:'calc(5px * 3px / 6px)' is valid: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-properties-values-api/register-property-syntax-parsing.html [wpt.fyi]
- syntax:'<number>', initialValue:'calc(15 + (sign(100vh - 10px) * 5))' is valid: FAIL (Chrome: PASS, Safari: PASS)
- syntax:'<integer>', initialValue:'calc(15 + (sign(100vh - 10px) * 5))' is valid: FAIL (Chrome: PASS, Safari: PASS)
- syntax:'<angle>', initialValue:'calc(15deg + (sign(100vh - 10px) * 5deg))' is valid: FAIL (Chrome: PASS, Safari: PASS)
- syntax:'<time>', initialValue:'calc(15s + (sign(100vh - 10px) * 5s))' is valid: FAIL (Chrome: PASS, Safari: PASS)
- syntax:'<resolution>', initialValue:'calc(15dppx + (sign(100vh - 10px) * 5dpi))' is valid: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/typedom.html [wpt.fyi]: ERROR (Chrome: OK, Safari: OK)
- Computed * is reified as CSSUnparsedValue: FAIL (Chrome: PASS, Safari: PASS)
/css/css-properties-values-api/var-reference-registered-properties.html [wpt.fyi]
- Invalid values for registered properties are serialized as the empty string: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/css/css-properties-values-api/animation/custom-property-animation-resolution-comma-list.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-animation-resolution-space-list.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-animation-transform-function.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-transition-non-inherited-used-by-standard-property.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)
/css/css-properties-values-api/animation/custom-property-transition-percentage.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: OK, Safari: OK)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Blocks: 1937844

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 months ago

Depends on: 1938241

Pulsebot

Comment 3

•

2 months ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e99c47c806e [wpt PR 49730] - [css-properties-values-api] Test unit arithmetic separately, a=testonly https://hg.mozilla.org/integration/autoland/rev/c675ca2ec49d [wpt PR 49730] - Update wpt metadata, a=testonly

Atila Butkovits

Comment 4

•

2 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/1e99c47c806e
https://hg.mozilla.org/mozilla-central/rev/c675ca2ec49d

Status: NEW → RESOLVED

Closed: 2 months ago

status-firefox135: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 135 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 49730 - [css-properties-values-api] Test unit arithmetic separately

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

Firefox-only Failures

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Updated

Comment 3

Comment 4