1937823 - [wpt-sync] Sync PR 49731 - [Signature-based SRI] `Accept-Signature` should be singular.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49731 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49731
Details from upstream follow.

Mike West <[e-mail]> wrote:

[Signature-based SRI] Accept-Signature should be singular.

https://chromium-review.googlesource.com/c/chromium/src/+/6087895 landed
support for the Accept-Signatures header. Unfortunately, it's
defined1 as Accept-Signature (no s). Oops! This CL addresses the
inconsistency.

Bug: 383409575
Change-Id: I8b15dd8fbd6b87282faff8dabaf6214026eb9715

Reviewed-on: https://chromium-review.googlesource.com/6101876
WPT-Export-Revision: 93cb348f982e6457590419c7c73810c115d6deb5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0da2c5e4edbb63afbe211a7ae73578e034977515

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 14 subtests

Status Summary

Firefox

OK : 4
PASS : 29
FAIL : 36
ERROR: 1

Chrome

OK : 5
PASS : 43
FAIL : 22

Safari

OK : 4
PASS : 29
FAIL : 36
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /subresource-integrity/signatures/tentative/fetch.any.html [wpt.fyi]
  • fetch(): No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, matching integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, one valid integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/fetch.any.sharedworker.html [wpt.fyi]
  • fetch(): No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, matching integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, one valid integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/fetch.any.worker.html [wpt.fyi]
  • fetch(): No signature, valid integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, matching integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature, one valid integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, no integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, malformed integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, matching integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Invalid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Invalid signature, one valid integrity check: blocked.: FAIL (Chrome: FAIL, Safari: FAIL)
• /subresource-integrity/signatures/tentative/path.window.html [wpt.fyi]
  • fetch(): Valid signature (signature=:AEW2XbDmmBK71KBle0Dx1JAWAO7B4QdEH2Tw71c9nntjUmx8xF5t8xbsETRHFwULrvJ4STBFtdMVm5a7QIw5Cw==:), matching integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Valid signature (signature=:AEW2XbDmmBK71KBle0Dx1JAWAO7B4QdEH2Tw71c9nntjUmx8xF5t8xbsETRHFwULrvJ4STBFtdMVm5a7QIw5Cw==:), mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • <script>: Valid signature (signature=:AEW2XbDmmBK71KBle0Dx1JAWAO7B4QdEH2Tw71c9nntjUmx8xF5t8xbsETRHFwULrvJ4STBFtdMVm5a7QIw5Cw==:), mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • fetch(): Valid signature (signature=:NEmnhhW1aKxO+ReWQmmSF17i49ZEdtDC4lRI2CJDw2E/rz9j2a8f8kIwVk7W/BIuQ6kejTAQ2FReGmmkREXPDg==:), matching integrity check: loads.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fetch(): Valid signature (signature=:NEmnhhW1aKxO+ReWQmmSF17i49ZEdtDC4lRI2CJDw2E/rz9j2a8f8kIwVk7W/BIuQ6kejTAQ2FReGmmkREXPDg==:), mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • <script>: Valid signature (signature=:NEmnhhW1aKxO+ReWQmmSF17i49ZEdtDC4lRI2CJDw2E/rz9j2a8f8kIwVk7W/BIuQ6kejTAQ2FReGmmkREXPDg==:), mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
• /subresource-integrity/signatures/tentative/script.window.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • <script>: No signature, valid integrity check: loads.: FAIL (Chrome: PASS, Safari: FAIL)
  • <script>: Valid signature, mismatched integrity check: blocked.: FAIL (Chrome: PASS, Safari: FAIL)
  • <script>: Valid signatures, integrity check matches neither: blocked.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e944117fc3f
[wpt PR 49731] - [Signature-based SRI] `Accept-Signature` should be singular., a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4e944117fc3f