1937919 - [wpt-sync] Sync PR 49744 - layout: Never stretch indefinite intrinsic keywords other than `auto`

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49744
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

layout: Never stretch indefinite intrinsic keywords other than auto

Consider:

<div style="position: relative; width: 50px; height: 50px; border: solid; margin: 5px">
  <div style="position: absolute; top: 0; bottom: 0; height: max-content">
    <canvas width="25" height="25" style="background: cyan; height: 100%"></canvas>
  </div>
</div>

In order to determine the inline min/max-content sizes, we need a tentative block size as the input, which only takes extrinsic values into account.

In this case height: max-content is intrinsic, so we were treating it as height: initial, which would behave as a definite height: stretch. Therefore, the canvas was able to resolve its percentage.

However, it seems weird to treat an explicitly intrinsic keyword in an extrinsic way, and Blink doesn't do it. So now we treat the tentative block size as indefinite, therefore the percentage behaves as auto.

This adds a new test, we were previously failing 6 subtests, now only 3.

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#34672

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=653c6df2c21dba78ed45c704c7a229a8f7512636

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 60 subtests

Status Summary

Firefox

OK : 1
PASS: 48
FAIL: 12

Chrome

OK : 1
PASS: 60

Safari

OK : 1
PASS: 51
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-sizing/keyword-sizes-on-abspos.html [wpt.fyi]
  • .test 37: FAIL
  • .test 38: FAIL
  • .test 39: FAIL
  • .test 42: FAIL
  • .test 43: FAIL
  • .test 44: FAIL

New Tests That Don't Pass

• /css/css-sizing/keyword-sizes-on-abspos.html [wpt.fyi]
  • .test 35: FAIL (Chrome: PASS, Safari: FAIL)
  • .test 37: FAIL (Chrome: PASS, Safari: PASS)
  • .test 38: FAIL (Chrome: PASS, Safari: PASS)
  • .test 39: FAIL (Chrome: PASS, Safari: PASS)
  • .test 40: FAIL (Chrome: PASS, Safari: FAIL)
  • .test 42: FAIL (Chrome: PASS, Safari: PASS)
  • .test 43: FAIL (Chrome: PASS, Safari: PASS)
  • .test 44: FAIL (Chrome: PASS, Safari: PASS)
  • .test 45: FAIL (Chrome: PASS, Safari: FAIL)
  • .test 50: FAIL (Chrome: PASS, Safari: FAIL)
  • .test 55: FAIL (Chrome: PASS, Safari: FAIL)
  • .test 60: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0059c1eca8c
[wpt PR 49744] - layout: Never stretch indefinite intrinsic keywords other than `auto`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/97738a97bfeb
[wpt PR 49744] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e0059c1eca8c
https://hg.mozilla.org/mozilla-central/rev/97738a97bfeb