1938065 - Crash in [@ abort | webrtc::DesktopFrameIOSurface::Wrap]

Status: NEW

(Core :: WebRTC: Audio/Video, defect)

Description

[Andreas Pehrson [:pehrsons]]

Crash report: https://crash-stats.mozilla.org/report/index/5df4b03a-d093-411d-9dd0-6ca2c0241213

MOZ_CRASH Reason:

Redirecting call to abort() to mozalloc_abort

Top 10 frames:

0  libmozglue.dylib  MOZ_Crash(char const*, int, char const*)  mfbt/Assertions.h:317
0  libmozglue.dylib  mozalloc_abort  memory/mozalloc/mozalloc_abort.cpp:35
1  libmozglue.dylib  abort  memory/mozalloc/mozalloc_abort.cpp:88
2  XUL  rtc::webrtc_checks_impl::WriteFatalLog(std::__1::basic_string_view<char, std:...  third_party/libwebrtc/rtc_base/checks.cc:78
3  XUL  rtc::webrtc_checks_impl::WriteFatalLog(char const*, int, std::__1::basic_stri...  third_party/libwebrtc/rtc_base/checks.cc:84
3  XUL  rtc::webrtc_checks_impl::FatalLog(char const*, int, char const*, rtc::webrtc_...  third_party/libwebrtc/rtc_base/checks.cc:179
4  XUL  rtc::webrtc_checks_impl::LogStreamer<>::CallCheckOp<rtc::webrtc_checks_impl::...  third_party/libwebrtc/rtc_base/checks.h:264
4  XUL  rtc::webrtc_checks_impl::LogStreamer<rtc::webrtc_checks_impl::Val<(rtc::webrt...  third_party/libwebrtc/rtc_base/checks.h:313
4  XUL  rtc::webrtc_checks_impl::LogStreamer<rtc::webrtc_checks_impl::Val<(rtc::webrt...  third_party/libwebrtc/rtc_base/checks.h:313
4  XUL  rtc::webrtc_checks_impl::FatalLogCall<true>::operator&<rtc::webrtc_checks_imp...  third_party/libwebrtc/rtc_base/checks.h:342

---

I also hit this locally:

# Check failed: surfaceWidth >= offsetColumns + width (5120 vs. 8905)

STR:

• Prereq: MacOS >=15 with multiple monitors and a camera
• Go to https://mozilla.github.io/webrtc-landing/gum_test.html
• Click "Screen capture"
• Approve the prompt and share a window on one monitor
• In another tab go to https://mozilla.github.io/webrtc-landing/gum_test.html
• Click "Camera"
• In the status bar control panel for the screen capture, click "Presenter Overlay" -> "Large", then "Add Windows..." and select a window on the other monitor

Expected results:
Probably the second window visible in the screen capture stream, like when you do no Presenter Overlay, or Small Presenter Overlay

Actual results:
Crash due to the release assertion failure mentioned above

Crash rate is low which makes sense given the narrow use case. I cannot reproduce in Safari because they only allow a single window to be shared, nor in Chrome because they don't use SCContentSharingPicker.