1938121 - Firefox Translation shows blank square

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[ericd586]

Attachment: Light theme

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

Open webpage that Firefox offers to translate. Example: https://imgbase.ru/

Actual results:

Page is translated, but the urlbar doesn't show the language it is translated to.

Expected results:

Urlbar should indicate the language in the box next to the translation button.

Comment 1

[ericd586]

Attachment: Screenshot 2024-12-18 095905.png

Comment 2

[ericd586]

Zooming in, I can see a faint en. This is using the Light Theme. Switching to System theme - auto, the issue disappears.

Comment 3

[ericd586]

Attachment: System theme

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced on Nightly 135.0a1 2024-12-19 under Win 11 64-bit, mozregression points that the regressor is:

Found commit message:
Bug 1923306 - Make toolbars fields of default themes work better when on top of the toolbox. r=desktop-theme-reviewers,dao

This is still not perfect specially for dark mode (as per UX discussion,
we might want to tweak that to use transparent white rather than
transparent black), but it's an improvement.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1923306

:emilio, since you are the author of the regressor, bug 1923306, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1938121 - Clean up how we handle toolbarbutton icon colors. r=#theme

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1938121 - Derive an appropriate fill-attention-text color. r=#theme

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f413f6e3d12
Clean up how we handle toolbarbutton icon colors. r=desktop-theme-reviewers,extension-reviewers,dao,robwu

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/2f413f6e3d12

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e97efdcff46c
Derive an appropriate fill-attention-text color. r=desktop-theme-reviewers,dao

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1923306

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e97efdcff46c

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9445528 [details]
Bug 1938121 - Derive an appropriate fill-attention-text color. r=#theme

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: fixes regression on translation popups with default themes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward theming change.
• String changes made/needed: none
• Is Android affected?: No

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9445528 [details]
Bug 1938121 - Derive an appropriate fill-attention-text color. r=#theme

Approved for 135.0b3.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2394a8a7aee0

Comment 18

[Peter Magyari (Desktop QA)]

I have verified the fix on Beta 135.0b3 (20250108194830) and Nightly 136.0a1 (20250108093633).