1938149 - Implement optimized import path for Function.prototype.call.bind(DataView.prototype.get)

Status: NEW

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

V8 has code to recognize the following import pattern:

      _159: Function.prototype.call.bind(DataView.prototype.getUint8),
      _160: Function.prototype.call.bind(DataView.prototype.setUint8),
      _167: Function.prototype.call.bind(DataView.prototype.getUint32),
      _168: Function.prototype.call.bind(DataView.prototype.setUint32),
      _177: Function.prototype.call.bind(DataView.prototype.getFloat64),
      _178: Function.prototype.call.bind(DataView.prototype.setFloat64),

And emit optimized code for typed array access. We may want to see if we can do the same somehow.

Dart would like to use this for fast access to typed arrays.

Comment 1

[Ryan Hunt [:rhunt]]

This shows up in JetStream3 and would improve our score on the dart subtest by around 4%. It's not just the DataView builtins, it's also things like:

Number.prototype.toString
BigInt.prototype.toString
String.prototype.toLowerCase
String.prototype.indexOf

Comment 2

[Ryan Hunt [:rhunt]]

I'm going to first start optimizing Function.prototype.call.bind in bug 1882955. This bug can be for further optimizations when the targetFunction is a recognized builtin like DataView.