1938211 - [wpt-sync] Sync PR 49728 - [carousel] Improve scroll buttons scrolling code

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49728 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49728
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

[carousel] Improve scroll buttons scrolling code

This CL fixes the problem that zoom affects the scroll amount by reusing
scrolling logic from scroll manager code that is also used for page up
and page down buttons handling.

Fixed: 383552806
Change-Id: I581c91b99acf78159728b03e7f3173c6d1686a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097334
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Auto-Submit: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1398125}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c188b73a445675adfe855510980d6ef8b0285a4c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 6

Chrome

OK : 3
PASS : 2
FAIL : 1

Safari

OK : 3
FAIL : 3

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-overflow/scroll-buttons-activation-with-columns.html [wpt.fyi]: TIMEOUT
• /css/css-overflow/scroll-buttons-activation-with-zoom.html [wpt.fyi]: TIMEOUT
• /css/css-overflow/scroll-buttons-activation.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /css/css-overflow/scroll-buttons-activation-with-columns.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • CSS Overflow Test: ::scroll-button() activation with column scroll markers: TIMEOUT (Chrome: PASS, Safari: FAIL)
• /css/css-overflow/scroll-buttons-activation-with-zoom.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • ::scroll-button(inline-end) activation should scroll the same amount with zoom is the same as without zoom: TIMEOUT (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/scroll-buttons-activation.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • CSS Test: ::scroll-button() activation: TIMEOUT (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21c2339deac3
[wpt PR 49728] - [carousel] Improve scroll buttons scrolling code, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f01b76634027
[wpt PR 49728] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/21c2339deac3
https://hg.mozilla.org/mozilla-central/rev/f01b76634027