1938240 - [Wayland] Make VSync more reliable

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Right now we fire VSync event after fist paint which may lead to transparent / empty window if rendering depends on VSync.
Use emulated frame callback to fire Vsync events in gap after 'ready to draw' surface state and first buffer attached as Wayland sends frame callback to surfaces with buffer only.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1938240 [Wayland] Call WaylandVsyncSource::Init() explicitly as we should not ref/unref class in constructor r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1938240 [Wayland] Make WaylandVsyncSource to use emulated frame callbacks r?emilio

• Add extra state which indicates attached buffer
• Ensure emulated callbacks are only fired between ready to draw state and first buffer attached
• Remove support of emulated one-time frame callbacks as they're not used

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1938240 [Wayland] Remove widget.wayland.emulate-frame-callback r?emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99a5d038a292
[Wayland] Call WaylandVsyncSource::Init() explicitly as we should not ref/unref class in constructor r=emilio
https://hg.mozilla.org/integration/autoland/rev/9dd4c1951839
[Wayland] Make WaylandVsyncSource to use emulated frame callbacks r=emilio
https://hg.mozilla.org/integration/autoland/rev/fb657f0e3fbe
[Wayland] Remove widget.wayland.emulate-frame-callback r=emilio

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/99a5d038a292
https://hg.mozilla.org/mozilla-central/rev/9dd4c1951839
https://hg.mozilla.org/mozilla-central/rev/fb657f0e3fbe