Make crash reporter client always fall back to bundled locale
Categories
(Toolkit :: Crash Reporting, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: afranchuk, Assigned: afranchuk)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
In bug 1936809, a user encountered an issue where localization info was located but failed to load. In this case, we encounter a fatal error. However, we should instead fall back to loading the bundled (English) locale info. This may be confusing to a user, so maybe we should somehow still notify in the UI that the correct locale information failed to load.
|
Assignee | |
Comment 1•1 year ago
|
||
When loading locales, fall back to the bundled locale if any error
occurs. Previously, we only used the bundled locale if we couldn't
read the omnijar, however we didn't do so if we failed to parse the
locale information within the omnijar.
To better expose early errors, this rearranges the code to set the log
file as early as possible, and updates the file when we get more
information from parsing the extra file. Otherwise, some of the earlier
error paths might only be logging to stderr, which is difficult for
users access and provide to us in a bug.
This also adds a textbox with the full error source trace to the error
dialog. The trade-off here is that the first line will be localized
(when possible), however the rest of the error information will not be
(as the strings come from external code). This is fine, as this
information is mainly useful in bug reports (which is also why I made it
a textbox, for easy text selection).
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
Bug 1940763 ends up addressing the primary concern, however the patch is still valuable as it improves logging and adds more context to the error dialog.
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Description
•