Closed Bug 1938518 Opened 1 year ago Closed 1 year ago

Support boolean keys for GetElem/SetElem

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

(Whiteboard: [sp3])

Attachments

(1 file)

Bug 1938518 - Optimize boolean property keys in CacheIR. r?iain!
48 bytes, text/x-phabricator-request
Details | Review

See bug 1938100 comment 0 - react-stockcharts has a lot of these.

A lot of calls to IonGetPropertyIC::update on Speedometer 3 are for a megamorphic
property access in react-stockcharts where the key is either a string or a boolean.
Because we didn't support booleans, we deoptimized the IC completely.

With this patch we handle booleans similar to what we do for null and undefined.

Whiteboard: [sp3]
Severity: -- → N/A
Priority: -- → P1
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2937a82e90ee Optimize boolean property keys in CacheIR. r=iain

https://hg.mozilla.org/mozilla-central/rev/2937a82e90ee

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: