Closed
Bug 1938518
Opened 2 months ago
Closed 1 month ago
Support boolean keys for GetElem/SetElem
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
See bug 1938100 comment 0 - react-stockcharts has a lot of these.
Assignee | ||
Comment 1•2 months ago
|
||
A lot of calls to IonGetPropertyIC::update
on Speedometer 3 are for a megamorphic
property access in react-stockcharts where the key is either a string or a boolean.
Because we didn't support booleans, we deoptimized the IC completely.
With this patch we handle booleans similar to what we do for null
and undefined
.
Updated•2 months ago
|
Whiteboard: [sp3]
Updated•2 months ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-904
Updated•1 month ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2937a82e90ee
Optimize boolean property keys in CacheIR. r=iain
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•